feishin: use electron_31 #336655
Merged
feishin: use electron_31 #336655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As originally mentioned in NixOS#331868, feishin now [1] depends on Electron v31, which was not packaged at the time (NixOS#325428). It has since been fixed (by NixOS#333907). [1]: https://github.com/jeffvli/feishin/blob/f2beeef/package.json#L234
|
Result of 1 package built:
|
|
Works for me :) Thank you! |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.05
git worktree add -d .worktree/backport-336655-to-release-24.05 origin/release-24.05
cd .worktree/backport-336655-to-release-24.05
git switch --create backport-336655-to-release-24.05
git cherry-pick -x 3d159512d943d3868b393c2050776c01b828daa6 |
13 tasks
emilazy
added
backport release-24.05
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.05
git worktree add -d .worktree/backport-336655-to-release-24.05 origin/release-24.05
cd .worktree/backport-336655-to-release-24.05
git switch --create backport-336655-to-release-24.05
git cherry-pick -x 3d159512d943d3868b393c2050776c01b828daa6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
As originally mentioned in #331868, Feishin now depends on Electron v31, which was not packaged at the time (#325428).
It has since been fixed (by #333907).
Notifying contributors: @onny (and @jlbribeiro)
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.