Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-24.05]: backport nix code owner #336734

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Aug 23, 2024

Description of changes

So that the nix core team also get notified about backports.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Ma27 and others added 3 commits August 23, 2024 11:09
Using Lix now 🍦

(cherry picked from commit 7baa302)
I have no further plan to review CppNix code anymore as I will dedicate
myself to Lix development.

Co-authored-by: aleksana <me@aleksana.moe>
(cherry picked from commit bf7ddf8)
Update .github/CODEOWNERS

Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
(cherry picked from commit b6c51f7)
@Mic92
Copy link
Member Author

Mic92 commented Aug 23, 2024

Result of nixpkgs-review pr 336734 run on aarch64-darwin 1

@Mic92 Mic92 merged commit e775ab7 into NixOS:release-24.05 Sep 10, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants