Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.05] nuclei: add patch for CVE-2024-40641 #337225

Merged

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Aug 25, 2024

Description of changes

https://nvd.nist.gov/vuln/detail/CVE-2024-40641

Not bumping because the release containing the fix explicitly notes breaking changes: https://github.com/projectdiscovery/nuclei/releases/tag/v3.3.0

Temporarily enabled the added test which appears to pass for me. (comment Test files are not part of the release tarball does not appear to be accurate) (also I've just been made aware of #284568 which could make the testing situation a lot better for go packages)

Already bumped to 3.3.1 in unstable.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Contributor

@LeSuisse LeSuisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch looks OK and it fixes the POC provided in the official advisory (GHSA-c3q9-c27p-cw9h).

Result of nixpkgs-review pr 337225 run on x86_64-linux 1

1 package built:
  • nuclei

@LeSuisse LeSuisse merged commit d024f7a into NixOS:release-24.05 Aug 30, 2024
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants