tuxedo-keyboard: 3.2.14 -> 4.6.2

[papanito]

Description of changes

Fixes #337072

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[papanito]

@blanky0230 may you have a look. Would be really nice this fix could be merged.

[idlecodinggoats]

I've just been trying to use this update but I get a Unknown symbol tuxedo_is_compatible (err -2) in journalctl - do you not have this problem?

[papanito]

how exactly do you try it out? My nixos knowledge is still q bit limited

[idlecodinggoats]

I downloaded the raw default.nix from this pull request and placed it in my configuration directory i.e. /etc/nixos/tuxedo-keyboard/default.nix and in my configuration file (configuration.nix) added

boot.kernelModules = [ "tuxedo_keyboard" ];
boot.extraModulePackages = [ ( config.boot.kernelPackages.callPackage ./tuxedo-keyboard/default.nix { } ) ];

which mimics hardware.tuxedo-keyboard.enable = true; but uses your updated tuxedo-keyboard derivation. Then I do a nixos-rebuild test (or switch etc.). The module is then available via modprobe but won't load because of the Unknown symbol.

[papanito]

Mhh ok I can't build due to a conflict :-(

error: builder for '/nix/store/dsnl0nqpvkb0h0dplp694yif6y666hc4-linux-6.6.52-modules.drv' failed with exit code 25;
       last 1 log lines:
       > error: collision between `/nix/store/d4a8d8lk1fi3svqk8sfpfy7yigkckrvq-tuxedo-keyboard-6.6.52-3.2.14/lib/modules/6.6.52/clevo_acpi.ko' and `/nix/store/dr43l4pqlfs21hfshxhzfjjwngnwli62-tuxedo-keyboard-6.6.52-4.6.2/lib/modules/6.6.52/clevo_acpi.ko'
       For full logs, run 'nix log /nix/store/dsnl0nqpvkb0h0dplp694yif6y666hc4-linux-6.6.52-modules.drv'.
error: 1 dependencies of derivation '/nix/store/pd1jz4fqkg3b1xxh4pli4r41pvswxr6q-nixos-system-clawfinger-24.05.20240927.f651414.drv' failed to build

[h7x4]

Does this conflict with #336633?

[papanito]

Not sure, I added this

    kernelPackages = pkgs.linuxPackages_6_10;
    extraModulePackages = [ ( config.boot.kernelPackages.callPackage ./../../tuxedo-keyboard/default.nix { } ) ];

Which then fails with

error: builder for '/nix/store/7hgvnwy3pfvwhw4rxp8mhffsxf7gz14i-tuxedo-keyboard-6.10.11-3.2.14.drv' failed with exit code 2;
       last 10 log lines:
       >       |                     ^
       > /build/source/./src/clevo_acpi.c:189:18: note: in expansion of macro 'THIS_MODULE'
       >   189 |         .owner = THIS_MODULE,
       >       |                  ^~~~~~~~~~~
       > cc1: some warnings being treated as errors
       > make[3]: *** [/nix/store/l82lbbbf14fxqsn5wbgnvk7lilbn8bip-linux-6.10.11-dev/lib/modules/6.10.11/source/scripts/Makefile.build:244: /build/source/./src/clevo_acpi.o] Error 1
       > make[2]: *** [/nix/store/l82lbbbf14fxqsn5wbgnvk7lilbn8bip-linux-6.10.11-dev/lib/modules/6.10.11/source/Makefile:1934: /build/source] Error 2
       > make[1]: *** [/nix/store/l82lbbbf14fxqsn5wbgnvk7lilbn8bip-linux-6.10.11-dev/lib/modules/6.10.11/source/Makefile:240: __sub-make] Error 2
       > make[1]: Leaving directory '/nix/store/l82lbbbf14fxqsn5wbgnvk7lilbn8bip-linux-6.10.11-dev/lib/modules/6.10.11/build'
       > make: *** [Makefile:29: all] Error 2
       For full logs, run 'nix log /nix/store/7hgvnwy3pfvwhw4rxp8mhffsxf7gz14i-tuxedo-keyboard-6.10.11-3.2.14.drv'.
error: 1 dependencies of derivation '/nix/store/lc8n2kal64hzgkcrgk0fmlmv6a1hy2df-linux-6.10.11-modules.drv' failed to build
error: 1 dependencies of derivation '/nix/store/x240gksw1v1nsmp58hk98rnhmj8ks1x6-nixos-system-clawfinger-24.05.20240927.f651414.drv' failed to build

It takes the wrong driver version (3.2.14), so I guess I am doing something wrong anything

[idlecodinggoats]

Not sure, I added this

    kernelPackages = pkgs.linuxPackages_6_10;
    extraModulePackages = [ ( config.boot.kernelPackages.callPackage ./../../tuxedo-keyboard/default.nix { } ) ];

Which then fails with

error: builder for '/nix/store/7hgvnwy3pfvwhw4rxp8mhffsxf7gz14i-tuxedo-keyboard-6.10.11-3.2.14.drv' failed with exit code 2;
       last 10 log lines:
       >       |                     ^
       > /build/source/./src/clevo_acpi.c:189:18: note: in expansion of macro 'THIS_MODULE'
       >   189 |         .owner = THIS_MODULE,
       >       |                  ^~~~~~~~~~~
       > cc1: some warnings being treated as errors
       > make[3]: *** [/nix/store/l82lbbbf14fxqsn5wbgnvk7lilbn8bip-linux-6.10.11-dev/lib/modules/6.10.11/source/scripts/Makefile.build:244: /build/source/./src/clevo_acpi.o] Error 1
       > make[2]: *** [/nix/store/l82lbbbf14fxqsn5wbgnvk7lilbn8bip-linux-6.10.11-dev/lib/modules/6.10.11/source/Makefile:1934: /build/source] Error 2
       > make[1]: *** [/nix/store/l82lbbbf14fxqsn5wbgnvk7lilbn8bip-linux-6.10.11-dev/lib/modules/6.10.11/source/Makefile:240: __sub-make] Error 2
       > make[1]: Leaving directory '/nix/store/l82lbbbf14fxqsn5wbgnvk7lilbn8bip-linux-6.10.11-dev/lib/modules/6.10.11/build'
       > make: *** [Makefile:29: all] Error 2
       For full logs, run 'nix log /nix/store/7hgvnwy3pfvwhw4rxp8mhffsxf7gz14i-tuxedo-keyboard-6.10.11-3.2.14.drv'.
error: 1 dependencies of derivation '/nix/store/lc8n2kal64hzgkcrgk0fmlmv6a1hy2df-linux-6.10.11-modules.drv' failed to build
error: 1 dependencies of derivation '/nix/store/x240gksw1v1nsmp58hk98rnhmj8ks1x6-nixos-system-clawfinger-24.05.20240927.f651414.drv' failed to build

It takes the wrong driver version (3.2.14), so I guess I am doing something wrong anything

If you've got 'hardware.tuxedo-keyboard.enable = true;' or you are using `hardware.tuxedo-rs.enable = true;' or anything then it'll be pulling in the original 'tuxedo-keyboard' derivation. You'll need to add 'hardware.tuxedo-keyboard.enable = lib.mkForce false;' to prevent this original (3.2.14) derivation from being used.

For what its worth I think that #336633 does fix this problem - but it will need 'tuxedo-rs' to implement using 'tuxedo-drivers' rather than 'tuxedo-keyboard' if that's what you are using.

[papanito]

Ahh I see, that makes sense - I slowly getting the grasp of it....

[papanito]

I will close my PR, it's the same as #293017 (superseeded by #343483) or #329383 (closed)

But looks like #336633 is the one.

[blanky0230]

I will close my PR, it's the same as #293017 (superseeded by #343483) or #329383 (closed)

But looks like #336633 is the one.

Thanks for supporting though 👍 I'm just catching up with the review requests rn.