[Backport release-24.05] Heroic Games Launcher: 2.14.1 -> 2.15.1

[github-actions]

Bot-based backport to release-24.05, triggered by a label in #335737.

• Before merging, ensure that this backport is acceptable for the release.
  • Even as a non-commiter, if you find that it is not acceptable, leave a comment.

[emilazy]

@ofborg build heroic

[emilazy]

Depends on backport of #278800 and #331638.

[emilazy]

@ofborg eval
@ofborg build heroic

[emilazy]

Oh, this might be painful 🫠

[emilazy]

@aidalgol Do we have to use pnpm here? I guess it’s an upstream change? It seems like it might be quite painful to backport the machinery to 24.05. Maybe we’ll just have to leave this behind a knownVulnerabilities warning on 24.05, but that would be unfortunate.

[emilazy]

Or maybe it’s not so bad after all: #337344

Building an entire Electron to see if this works after that.

[emilazy]

@ofborg build heroic

[emilazy]

@ofborg eval

[emilazy]

FWIW this builds fine, but I’d like someone else to check it before merging.

[aidalgol]

Do we have to use pnpm here? I guess it’s an upstream change?

Yes, it was an upstream change.

FWIW this builds fine, but I’d like someone else to check it before merging.

I just checked out the branch for this PR and tried building heroic, and it looks like comet-gog is missing.

error: evaluation aborted with the following error message: 'lib.customisation.callPackageWith: Function called without required argument "comet-gog" at /home/aidan/src/nixpkgs/pkgs/games/heroic/default.nix:12'

I'm not sure why this didn't cause ofborg-eval to fail.

[emilazy]

I backported comet-gog and the entire pnpm machinery in separate PRs. You’ll have to rebase this branch on the latest release-24.05 to be able to build it. ofborg goes off what the tree will be after merging, rather than the HEAD of the PR branch.

[aidalgol]

Builds and runs OK for me.