Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.05] morgen: electron_29 -> electron_30 #337320

Merged
merged 7 commits into from
Aug 27, 2024

Conversation

emilazy
Copy link
Member

@emilazy emilazy commented Aug 25, 2024

Description of changes

Manual backport of #336026.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@emilazy
Copy link
Member Author

emilazy commented Aug 25, 2024

Result of nixpkgs-review pr 337320 run on x86_64-linux 1

1 package built:
  • morgen

@emilazy
Copy link
Member Author

emilazy commented Aug 26, 2024

@justanotherariel Do you know if 3.4.2 will work with Electron 30 or if we need to backport the 3.5.5 update as well?

@justanotherariel
Copy link
Contributor

Hm, I can't test it because it complains that I'm downgrading - I would need to remove all related files first and I don't want to break things on my machine. I'd say, it's likely that it will still work, but since there are no breaking changes (just added features and performance improvements) in morgen version 3.5.5, probably just upgrade? Just to be on the safe side.

r-ryantm and others added 7 commits August 26, 2024 15:12
(cherry picked from commit ceb8e1a)
(cherry picked from commit 62942da)
(cherry picked from commit 286beb5)
(cherry picked from commit 40eb861)
(cherry picked from commit 47c6c7b)
(cherry picked from commit 48a9a6a)
(cherry picked from commit 4a463f1)
@emilazy
Copy link
Member Author

emilazy commented Aug 26, 2024

@justanotherariel I’ve backported the bumps – please take a look :)

Copy link
Contributor

@justanotherariel justanotherariel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emilazy emilazy merged commit 80d50ab into NixOS:release-24.05 Aug 27, 2024
24 of 25 checks passed
@emilazy emilazy deleted the push-wwqsozszxown branch August 27, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants