Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.05] pnpm{,_8,_9,.fetchDeps}: init #337344

Merged
merged 17 commits into from
Aug 26, 2024

Conversation

emilazy
Copy link
Member

@emilazy emilazy commented Aug 25, 2024

Description of changes

Manual backport of #290715, #319042, #320124, #317739, #322753, #325837, #323493, and #332966, omitting the changes that touched existing packages. Brings pnpm.fetchDeps support to 24.05 to be used for backports. I’ve verified that the port of kiwitalk from the original PR compiles on 24.05 after these commits, so the functionality works.

Since this doesn’t change any existing packages and just adds new functionality it should be fine to backport, but it is pretty heavy. The motivating example is #337312, where a package was ported to a non‐EOL Electron but switched to pnpm.fetchDeps in the process.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Scrumplex and others added 17 commits August 25, 2024 22:36
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
(cherry picked from commit 4549773)
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
(cherry picked from commit 53af969)
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
(cherry picked from commit 74f5ff7)
This script allows users to reuse the cached dependencies outside of
derivations.

Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
(cherry picked from commit 728d482)
(cherry picked from commit 6ff6c42)
(cherry picked from commit b331e60)
(cherry picked from commit 49d9dda)
(cherry picked from commit 7affedd)
(cherry picked from commit a04915f)
(cherry picked from commit 1d8ea76)
Co-authored-by: Niklas Korz <niklas@niklaskorz.de>
(cherry picked from commit 7eaa7e8)
(cherry picked from commit 57c288b)
@emilazy
Copy link
Member Author

emilazy commented Aug 26, 2024

I’ve confirmed that #337312 builds on top of this; merging. Thanks for the reviews!

@emilazy emilazy merged commit c500631 into NixOS:release-24.05 Aug 26, 2024
27 of 29 checks passed
@emilazy emilazy deleted the push-txtsrpvmkukn branch August 26, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants