Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

microsoft-edge: 128.0.2739.42 -> 128.0.2739.54 #338763

Merged
merged 1 commit into from
Sep 8, 2024

Conversation

r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented Sep 1, 2024

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for microsoft-edge is: Web browser from Microsoft

meta.homepage for microsoft-edge is: https://www.microsoft.com/en-us/edge

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact

Checks done


  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 128.0.2739.54 with grep in /nix/store/pvzm9vdyrldkyd21ja5md01asnm1p0kn-microsoft-edge-stable-128.0.2739.54
  • found 128.0.2739.54 in filename of file in /nix/store/pvzm9vdyrldkyd21ja5md01asnm1p0kn-microsoft-edge-stable-128.0.2739.54

Rebuild report (if merged into master) (click to expand)
4 total rebuild path(s)

4 package rebuild(s)

First fifty rebuilds by attrpath

microsoft-edge
microsoft-edge-beta
microsoft-edge-dev
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/pvzm9vdyrldkyd21ja5md01asnm1p0kn-microsoft-edge-stable-128.0.2739.54 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A microsoft-edge https://github.com/r-ryantm/nixpkgs/archive/e6e452ff00e9d6219cdcc9c8aa7abac6882ff315.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/e6e452ff00e9d6219cdcc9c8aa7abac6882ff315#microsoft-edge

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/pvzm9vdyrldkyd21ja5md01asnm1p0kn-microsoft-edge-stable-128.0.2739.54
ls -la /nix/store/pvzm9vdyrldkyd21ja5md01asnm1p0kn-microsoft-edge-stable-128.0.2739.54/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

3 packages built:
  • microsoft-edge
  • microsoft-edge-beta
  • microsoft-edge-dev

Maintainer pings

cc @zanculmarktum @kuwii @rhysmdnz for testing.

Tip

As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.


Add a 👍 reaction to pull requests you find important.

Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works fine on x86_64-linux

@natsukium natsukium merged commit a1851c2 into NixOS:master Sep 8, 2024
28 of 29 checks passed
Copy link
Contributor

github-actions bot commented Sep 8, 2024

Successfully created backport PR for release-24.05:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants