-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport release-24.05] bookstack: 24.05.3 -> 24.05.4 #339492
base: release-24.05
Are you sure you want to change the base?
[Backport release-24.05] bookstack: 24.05.3 -> 24.05.4 #339492
Conversation
(cherry picked from commit a8f5ef6)
Should the test fail? |
|
i've checked the changes and they match what the latest master has. i think this cherry-pick test fails as NixOS 24.04 had bookstack upgrade v24.05.3 -> v24.05.4 and the unstable had v24.05.2 -> v24.05.4. So when i cherry-picked it, i used |
I know, we are using github status' wrong.
|
The cherry-pick weirdness here is because somehow the stable branch ended up with 24.05.3 while master remained on 24.05.2. I would probably just remove the cherry-pick line from the commit message as it's just not closely related enough. |
(cherry picked from commit a8f5ef6)
Description of changes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.
#338990