-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zfs_2_2: 2.2.5 -> 2.2.6 #339696
zfs_2_2: 2.2.5 -> 2.2.6 #339696
Conversation
- This release brings official support for Kernel 6.10 - Also update zfs_unstable as it would otherwise lag behind - Upstream now links `zpool` completion, so only do so on older zfs (since we still need to support 2.1.x) Changelog: https://github.com/openzfs/zfs/releases/tag/zfs-2.2.6
looks like a lot 6.11 compat merged as well … maybe good enough to compile with 6.11 for |
I don't think that's a good idea, maybe OpenZFS team had a reason not to mark it compatible with 6.11 |
Does anyone know how to lock the kernel version? zfs is slower for the latest kernel, plus mergers, etc., and cannot be updated for a long time. |
@eqfae See the manual. |
Can you elaborate on slower ? For reference for others that pin to the latest zfs compatible kernel |
I personally recommend pinning to a specific kernel release line, e.g. For example, imagine 6.6 is the LTS and 6.9 is the latest kernel. When 6.10 is released, the kernel team will drop 6.9 as it is no longer patched upstream. If zfs is not compatible (it's not) on day one of the release, latestCompatibleLinuxPackages will now resolve to 6.6, forcing a downgrade. In this scenario I'd pin to |
thank you, I hadn't thought on that. Will apply your suggestion. |
在youtube有评测结果lqx内核为游戏提供最佳的性能 2.2.5-6.9.11是其zfs最新可用的内核 There are reviews on youtube with results of the lqx kernel providing the best performance for gaming 2.2.5-6.9.11 is the latest available kernel for its zfs |
@@ -184,6 +184,7 @@ let | |||
|
|||
# Add Bash completions. | |||
install -v -m444 -D -t $out/share/bash-completion/completions contrib/bash_completion.d/zfs | |||
'' + optionalString (lib.versionOlder version "2.2.6") '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has broken the 2.1 build, btw.
/nix/store/ffr5qkpiyl0bdz15w1b8hmqnclw6938h-stdenv-linux/setup: line 229: cd: /nix/store/hn1s5py5wfinj0k1wq7ghhzwv19ahc72-zfs-kernel-2.1.15-6.6.49/share/bash-completion/completions: No such file or directory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, this is not conditional on buildUser
. In fact, I actually think the line above it isn't even necessary in 2.2.*. Will add this to my zfs fixes pr: #340165
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.05
git worktree add -d .worktree/backport-339696-to-release-24.05 origin/release-24.05
cd .worktree/backport-339696-to-release-24.05
git switch --create backport-339696-to-release-24.05
git cherry-pick -x 636134b8ed2112412c1da441b4cc4d47a24e3bd3 |
Can someone take care of the stable backport? |
@mweinelt Yes, I will sometime later today. |
@mweinelt to 2.2.6? I think @amarshall was giving it more time but recently did #340074 |
Yes I’ll open it later today but will do as draft and let it sit for a few days. |
Whatever will provide support for 6.10 :) |
zpool
completion, so only do so on older zfs (since we still need to support 2.1.x)Changelog: https://github.com/openzfs/zfs/releases/tag/zfs-2.2.6
Description of changes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.