Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

undocker: 1.2.2 -> 1.2.3 #341364

Merged
merged 1 commit into from
Sep 16, 2024
Merged

undocker: 1.2.2 -> 1.2.3 #341364

merged 1 commit into from
Sep 16, 2024

Conversation

motiejus
Copy link
Contributor

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)

@ofborg ofborg bot requested a review from jordanisaacs September 12, 2024 16:44
@AndersonTorres
Copy link
Member

Reword the commit according to the guidelines.

undocker: 1.2.2 -> 1.2.3

Or don't. I am not a cop.

@motiejus motiejus changed the title [undocker] 1.2.2 -> 1.2.3 [ndocker: 1.2.2 -> 1.2.3 Sep 12, 2024
@motiejus motiejus changed the title [ndocker: 1.2.2 -> 1.2.3 undocker: 1.2.2 -> 1.2.3 Sep 12, 2024
@JohnRTitor
Copy link
Contributor

Result of nixpkgs-review pr 341364 run on x86_64-linux 1

1 package built:
  • undocker

@JohnRTitor
Copy link
Contributor

Or don't. I am not a cop.

Regardless I am gonna squash merge to make it appropriate anyway

@JohnRTitor JohnRTitor merged commit 89217d3 into NixOS:master Sep 16, 2024
35 checks passed
@motiejus
Copy link
Contributor Author

Thanks! ❤️

@motiejus motiejus deleted the undocker-v1.2.3 branch September 16, 2024 12:52
@motiejus motiejus added the backport release-24.05 Backport PR automatically label Sep 16, 2024
github-actions bot pushed a commit that referenced this pull request Sep 16, 2024
@motiejus @github-actions
undocker: 1.2.2 -> 1.2.3 (#341364)
d38e757 
(cherry picked from commit 89217d3)
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-24.05:

@github-actions github-actions bot mentioned this pull request Sep 16, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordanisaacs jordanisaacs jordanisaacs approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer 12.approvals: 1 12.approved-by: package-maintainer backport release-24.05 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@motiejus @AndersonTorres @JohnRTitor @jordanisaacs @wegank