[24.05] Revert "zfs: dynamically determine latestCompatibleLinuxPackages" #342495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 27b52ad. Fixes NixOS#341867 We could select linux_6_10 now if we wanted but I opted for linux_6_6 instead because this will be removed anyways. This is technically a breaking change but latestCompatibleLinuxPackages has no expectancy of stability in the first place.
13 tasks
Atemu
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
Atemu
deleted the
revert/zfs/dynamically-determine-latestCompatibleLinuxPackages
branch
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 27b52ad.
Fixes #341867
We could select linux_6_10 now if we wanted but I opted for linux_6_6 instead because this will be removed anyways.
This is technically a breaking change but latestCompatibleLinuxPackages has no expectancy of stability in the first place.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.