Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdemu: update packages #342549

Merged
merged 1 commit into from
Sep 18, 2024
Merged

cdemu: update packages #342549

merged 1 commit into from
Sep 18, 2024

Conversation

bendlas
Copy link
Contributor

@bendlas bendlas commented Sep 17, 2024

Description of changes

cdemu-daemon: 3.2.6 -> 3.2.7
libmirage: 3.2.7 -> 3.2.9
linuxPackages.vhba: 20240202 -> 20240917

fix #342530

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

cdemu-daemon: 3.2.6 -> 3.2.7
libmirage: 3.2.7 -> 3.2.9
linuxPackages.vhba: 20240202 -> 20240917
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@keenanweaver
Copy link
Member

Result of nixpkgs-review pr 342549 run on x86_64-linux 1

23 packages built:
  • cdemu-daemon
  • image-analyzer
  • libmirage
  • linuxKernel.packages.linux_4_19.vhba
  • linuxPackages_4_19_hardened.vhba (linuxKernel.packages.linux_4_19_hardened.vhba)
  • linuxKernel.packages.linux_5_10.vhba
  • linuxPackages_5_10_hardened.vhba (linuxKernel.packages.linux_5_10_hardened.vhba)
  • linuxKernel.packages.linux_5_15.vhba
  • linuxPackages_5_15_hardened.vhba (linuxKernel.packages.linux_5_15_hardened.vhba)
  • linuxKernel.packages.linux_5_4.vhba
  • linuxPackages_5_4_hardened.vhba (linuxKernel.packages.linux_5_4_hardened.vhba)
  • linuxKernel.packages.linux_6_1.vhba
  • linuxKernel.packages.linux_6_10.vhba
  • linuxPackages_latest.vhba (linuxKernel.packages.linux_6_11.vhba)
  • linuxPackages_6_1_hardened.vhba (linuxKernel.packages.linux_6_1_hardened.vhba)
  • linuxPackages.vhba (linuxKernel.packages.linux_6_6.vhba)
  • linuxPackages_hardened.vhba (linuxPackages_6_6_hardened.vhba)
  • linuxPackages_latest-libre.vhba (linuxKernel.packages.linux_latest_libre.vhba)
  • linuxPackages-libre.vhba (linuxKernel.packages.linux_libre.vhba)
  • linuxPackages_lqx.vhba (linuxKernel.packages.linux_lqx.vhba)
  • linuxPackages_xanmod.vhba (linuxKernel.packages.linux_xanmod.vhba)
  • linuxPackages_xanmod_latest.vhba (linuxKernel.packages.linux_xanmod_latest.vhba ,linuxPackages_xanmod_stable.vhba)
  • linuxPackages_zen.vhba (linuxKernel.packages.linux_zen.vhba)

Copy link
Member

@keenanweaver keenanweaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing the issue so quickly!

@bendlas
Copy link
Contributor Author

bendlas commented Sep 18, 2024

https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#commit-conventions

Not applicable, as there are multiple packages with multiple versions. Version numbers are in commit description.

@bendlas bendlas merged commit 366e562 into NixOS:master Sep 18, 2024
25 checks passed
@dotlambda
Copy link
Member

Excuse me??
Make it one commit per package.

dotlambda added a commit that referenced this pull request Sep 18, 2024
@SuperSandro2000
Copy link
Member

Not applicable, as there are multiple packages with multiple versions. Version numbers are in commit description.

For multiple packages there should be multiple commits. That's how we are doing it for years.

@bendlas
Copy link
Contributor Author

bendlas commented Sep 18, 2024

Excuse me?? Make it one commit per package.

Are you serious? Reverting a working commit that fixes a bug out of spite?!

cc @NixOS/moderation please tell em, before I get spicy again

@bendlas
Copy link
Contributor Author

bendlas commented Sep 18, 2024

Not applicable, as there are multiple packages with multiple versions. Version numbers are in commit description.

For multiple packages there should be multiple commits. That's how we are doing it for years.

I would have squashed the PR anyway, so what's the difference?

@dotlambda
Copy link
Member

I would have squashed the PR anyway, so what's the difference?

Please don't do that. It would render the commit guidelines pointless.

@piegamesde
Copy link
Member

To add insult to injury, this was a self-merge. I don't know if someone showing such disrespect for our contribution process should be wielding the rights to commit to Nixpkgs.

@bendlas
Copy link
Contributor Author

bendlas commented Sep 18, 2024

I know that @NixOS/moderation is currently catching up on everything, and I promised to wait for them until I respond further.

But since this is now crossing over into bullying / harrassment / dogpiling again (and I do in fact have emotions as well), I will now lock this thread. Even if you have the ability to circumvent the lock, please take a moment to consider your facts and your goals, before doing so.

@NixOS NixOS locked as too heated and limited conversation to collaborators Sep 18, 2024
@emilazy
Copy link
Member

emilazy commented Sep 18, 2024

While the commit message thing here is a pretty mild violation of our contribution guidelines, and I think @dotlambda’s reaction was excessive, @bendlas’s self‐merge after disregarding the review comments and reaction to pushback, combined with his other recent behaviour, does force me to the conclusion that he is either incapable or unwilling to productively participate collaboratively in our shared project, and that his attitude towards others falls short of what we ought to expect for a committer.

For the benefit of the moderation team, since they have been pinged anyway, I will link recent incidents where I found his behaviour outside of the bounds of acceptable conduct for Nixpkgs (even though I would say the same of some of his interlocutors in them too), though moderators already posted in or were pinged with regards to several of these already:

  1. https://discourse.nixos.org/t/can-we-please-stop-breaking-stuff-willy-nilly/48496, nixos/fcgiwrap: refactor to fix permissions #318599, [24.05] backport fcgiwrap instances fix for local privilege escalation issue #331465

  2. treewide: decomissionate urandom #337478

  3. maintainers/scripts/activity: review management tool #340663 (comment)

I am not sure if the jurisdiction here falls properly under the moderation team or the Nixpkgs committer delegation team, but sadly I have found @bendlas to regularly be the centre of deeply unpleasant threads that waste a lot of contributor time and frequently involve him directing flippant snark at others after they escalate to the point of being referred to the moderation team.

I won’t post further in this thread before the moderation team gets to it, as I have no desire to encourage any pile‐ons or get involved in one of these situations again, but given that this is the fourth incident in less than three months I felt it important to point to some of the context here.

@NixOS NixOS unlocked this conversation Sep 18, 2024
@bendlas
Copy link
Contributor Author

bendlas commented Sep 18, 2024

Results are in and I have been formally warned by the mod team, as a first step towards getting banned.


@emilazy I am deeply, deeply disappointed that you decided to circumvent the lock, especially since you seem to be looked at as an arbiter of justice by some.

I also think that in your list, you may have forgot the one instance, where I complained about a 2-weeks ultimatum being given to maintainers

  1. Rust 1.80.0 breaks some packages #332957 (comment)

I do think I have more than adequate justifications for each of the instances listed, but as I've predicted, nobody is going to try to hear it, we're all doing this for fun and in our free time, aren't we?

@bendlas’s self‐merge

Just out of interest: Is anybody, who's been using this argument aware, that I've not only been the sole maintainer for the cdemu packages, but also its original creator?

In fact, cdemu was the very first thing, that I packaged for NixOS, back when we were still desperate for help. The experience is what gave me confidence enough to go all-in on NixOS, because even as a novice I could create a package with a kernel module, and it's still holding up today!

Since that package is actually the reason I got my maintainer status, I think it will be more than a little poetic if it's also the reason I'm leaving. That's the kind of drama, I'm actually here for 😍

deeply unpleasant threads that waste a lot of contributor time and frequently involve him directing flippant snark

So many other things to respond to, so little time. I'm picking this, because it perfectly embodies the "whack-a-mole" mentality, that seems to be taking hold in the community: Me being the mole, that dared raise its head and speak.

  • Real change is never pleasant. You rustaceans should know by now, or how's that introduction to linux going for you?
  • It's hard to stay level-headed, when you're straw-manned to death by flying monkeys. I personally think, I've done an above-average job on this, never resorting to personal insults in exchange. may the fates treat you more favorably, when it's your turn in the outgroup.
  • I think wasted time can actually be a good thing, if the direction we're going is wrong
    • especially if it's not "wasted" but actually makes people think about what we're doing. I may have failed on that one
  • I think flippant snark is a very adequate reaction, when faced with the insinuation that you shouldn't have a voice in the conversation

Make it one commit per package.

@dotlambda you broke it, you fix it. I've re-opened the original issue and put you as owner. I think this is fair, because even my harshest critics seem to agree that using the commit log to carry out a grudge is way over the line.


Where does this leave us?

I'm not gone yet, but I am also deeply disappointed in the mod team's idea of mediation - just a moderator interrogating me. There was no negotiation with counterparties, no weighing of facts, and the reason I'm the only one being formally warned is because apparently "everybody" (?) else apologized (in private? to the mod team?). And now the "mediation" is over and everybody has better things to do 😒

I already knew thought [1] that there was no appeal process, despite the warning being called "formal" (yes I know, nobody wants to hear it!). It still stings when its your turn. Trust me.

[1] EDIT After short research, I have found: https://discourse.nixos.org/t/is-there-a-process-for-appealing-a-moderator-decision/44599/36 For that mistake, I'd like to ask y'alls forgiveness.

To summarize: The overwhelming trust advance that I held for the mod team is squandered. I kind of feel like a fool now for trolling the RFC-175 folks as hard as I did, just a few weeks ago, and partaking in the laughter when people told me "those never contributed anything to nixos".

EDIT I want to add here, that despite that sentiment, I still trust the NixOS Moderation Team and I value them as an interest group, doing hard and important work for nixos - similar to our bulk reviewers. I am glad we have y'all. I do accept the formal warning on a provisional basis and am currently seeking dialogue with moderation@nixos.org


And to everybody who's been ganging up on me, instead of seeking dialogue: Rest assured that I will be more careful with my wording from now on

2024-09-18_22-35

To everybody at all: My DMs remain open

P.S.:

Please somebody more adept in tone policing tell me if this message is within bounds. I honestly have a hard time telling.

P.P.S.:

either incapable or unwilling to productively participate

@emilazy you know what I want to tell you to do with that statement, don't you?

EDIT reflect on it, that is. like ... actually take a moment to reflect on it, try to take my view for a second and tell me what you think my reasons could be, that in all my time here, I have never said anything closely as hurtful about anybody trying to contribute. Like, even if they were ... like ... really annoying, right? Like ... not even if it wasn't as easily disproven as in my case, right? Like ... even if they were new and might as well have been trolling, or if they were old and quirky and way too full of themselves, or even just if they ought to have known better, right?

That said: What I think, I'm bringing to the project, politically, so far:

  • I value backwards compatibility, I think it flows naturally from the same "unobviousity" that makes value types and functional programming click like they do. and same as with value types, it only works if nobody cheats.
  • I think we should be extra respectful when dealing with changes of people's statuses with the NixOS project. Same as it feels good to get a warm welcome when you join a team, it's also nice to treat goodbyes with dignity.
  • I expect reviewers to maintain their level of insistence on review items, proportional to their level of insight into the particular PR.

And for the record:

  • I don't think DEI is a slur
  • I do think a weapons manufacturer should know better than to demand their stinking logo on our project, go nixos community

And yes: If I feel any of these values threatened, I can get a bit spicy. Just tell me where the line is, I can stay within it.

What are you standing in for, politically? What would you be willing to go to the line for?

P.P.P.S.: I'll stop after this, but that's just too good to be left unsaid:

I am not sure if the jurisdiction here falls properly under the moderation team or the Nixpkgs committer delegation team,

To quote the mod team member dealing with me; they allowed me to quote them, as long as I made clear that it was from the "mediation" phase, and not an official mod team statement:

2024-09-18_23-08

@NixOS NixOS locked as too heated and limited conversation to collaborators Sep 18, 2024
@picnoir
Copy link
Member

picnoir commented Sep 18, 2024

Moderation team hat on:

Let's not escalate the tension further. Locking for now. Please refrain to respond, feel free to mute the PR.

@bendlas
Copy link
Contributor Author

bendlas commented Sep 18, 2024

That's fine, just for completeness sake: to be concluded here #342883

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: cdemu
7 participants