Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

saga: 9.3.2 -> 9.5.1 #343504

Merged
merged 4 commits into from
Oct 5, 2024
Merged

saga: 9.3.2 -> 9.5.1 #343504

merged 4 commits into from
Oct 5, 2024

Conversation

autra
Copy link
Contributor

@autra autra commented Sep 21, 2024 •
edited
Loading

Description of changes

saga: 9.3.2 -> 9.5.1

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@autra
Copy link
Contributor Author

autra commented Sep 21, 2024 •
edited
Loading

Trying to open a file segfaults on my machine (maybe wayland-related?)

EDIT: it builds fine though.

@l0b0 l0b0 removed their request for review September 21, 2024 19:52
@autra autra self-assigned this Oct 4, 2024
@ofborg ofborg bot requested a review from l0b0 October 4, 2024 12:11
@autra
Copy link
Contributor Author

autra commented Oct 4, 2024

Result of nixpkgs-review pr 343504 run on x86_64-linux 1

1 package built:
  • saga

@autra autra marked this pull request as ready for review October 4, 2024 17:53
@autra
Copy link
Contributor Author

autra commented Oct 4, 2024

wrapGAppsHook3 was missing, causing crashes about gsettings schemas not found. I've added a commit fixing that. This is ready now.

imincik
imincik approved these changes Oct 5, 2024
View reviewed changes
Copy link
Contributor

@imincik imincik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you !

@imincik imincik merged commit f0c592c into NixOS:master Oct 5, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imincik imincik imincik approved these changes

@nh2 nh2 Awaiting requested review from nh2

@willcohen willcohen Awaiting requested review from willcohen

@nialov nialov Awaiting requested review from nialov

@sikmir sikmir Awaiting requested review from sikmir

@l0b0 l0b0 Awaiting requested review from l0b0

Assignees

@autra autra

Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@autra @imincik @wegank