-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nix 2.24 upgrade #343655
Nix 2.24 upgrade #343655
Conversation
c178f1e
to
061cedf
Compare
This reverts commit b3b9bdd.
061cedf
to
af7bcfa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Release notes didn't get reverted and are still present on rl-2411
Mic92, just an idea (not a request / completely to your consideration), Maybe target the current staging-next cycle to test before a broader rollout? (It isn't many rebuilds and could go directly to the main branch but due to the criticallity of nix for NixOS might be preferable to reduce the blast radius a bit) |
Sounds good. Also we can than fix instead of revert. |
I found some issue with the nix-upgrade test. We need to patch switch-to-configuration to ignore /nix/store transient units. |
Also I think this is issue would also happen with the current nix version as systemd creates a nix-store.mount unit that it than tries to unmount. |
So the nix-update tests revealed a regression in switch-to-configuration-ng, which needs to be fixed nevertheless as it will break any nix update: #343709 |
Result of 1 package blacklisted:
2 packages failed to build:
93 packages built:
|
@@ -31,7 +30,7 @@ stdenv.mkDerivation (finalAttrs: { | |||
buildInputs = [ | |||
boost | |||
howard-hinnant-date | |||
nix | |||
nixVersions.nix_2_18 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @2xsaiko
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't build with nix 2.24.
This reverts commit 7d10007.
b07033c
to
829636f
Compare
@vcunat gave me green light to merge this to staging-next. |
829636f broke the test eval in
|
Proposed a simple fix as: |
Description of changes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.