Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix: update nix-fallback-paths #343716

Merged
merged 1 commit into from
Sep 22, 2024
Merged

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Sep 22, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Mic92
Copy link
Member Author

Mic92 commented Sep 22, 2024

cc @Aleksanaa

We also need to backport this.

@Mic92 Mic92 removed the request for review from RaitoBezarius September 22, 2024 12:45
@Mic92 Mic92 added the backport release-24.05 Backport PR automatically label Sep 22, 2024
@Mic92 Mic92 merged commit f05d081 into NixOS:master Sep 22, 2024
23 of 25 checks passed
@Mic92 Mic92 deleted the missing-nix-update-hash branch September 22, 2024 13:44
Copy link
Contributor

Backport failed for release-24.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.05
git worktree add -d .worktree/backport-343716-to-release-24.05 origin/release-24.05
cd .worktree/backport-343716-to-release-24.05
git switch --create backport-343716-to-release-24.05
git cherry-pick -x 8999c869a860674baf6ddd81716f81ebc616a21e

@Mic92
Copy link
Member Author

Mic92 commented Sep 22, 2024

Backport: #343725

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant