-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.mkdocs-git-committers-plugin-2: init at 2.4.1 #344615
base: master
Are you sure you want to change the base?
python3Packages.mkdocs-git-committers-plugin-2: init at 2.4.1 #344615
Conversation
pkgs/development/python-modules/mkdocs-git-committers-plugin-2/default.nix
Outdated
Show resolved
Hide resolved
pkgs/development/python-modules/mkdocs-git-committers-plugin-2/default.nix
Outdated
Show resolved
Hide resolved
pkgs/development/python-modules/mkdocs-git-committers-plugin-2/default.nix
Outdated
Show resolved
Hide resolved
]; | ||
|
||
pythonImportsCheck = [ "mkdocs_git_committers_plugin_2" ]; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you enable tests?
Make sure the tests are enabled using for example pytestCheckHook and, in the case of libraries, are passing for all interpreters. If certain tests fail they can be disabled individually. Try to avoid disabling the tests altogether. In any case, when you disable tests, leave a comment explaining why.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, the upstream package does not have any test suite, and since it is a plugin that has to do with Git history, mocking one would be pretty complicated I feel. I explicitly disabled the check for now, but if there's any better way to do it, please let me know!
@natsukium thanks for the review! (and apologies for the rookie mistakes.) I believe I have addressed most (if not all) of your concerns, would you mind having another look? |
Signed-off-by: Luka Leer <luka.leer@gmail.com>
Signed-off-by: Luka Leer <luka.leer@gmail.com>
Signed-off-by: Luka Leer <luka.leer@gmail.com>
Signed-off-by: Luka Leer <luka.leer@gmail.com>
0324ec9
to
fa99aa3
Compare
(Same as #343787, renamed branch in my repo. Apologies for spam.)
Description of changes
ojacques/mkdocs-git-committers-plugin-2
, primarily used as an optional dependency of Material for MkDocs.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.