Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.05] linux_6_11: fix perf #344636

Closed
wants to merge 1 commit into from

Conversation

phip1611
Copy link
Contributor

@phip1611 phip1611 commented Sep 26, 2024

Description of changes

EDIT: Ehhh... no idea why a gazillion of reviewers have been requested automatically. Sorry! This wasn't my intention.

Follow-up of #342134 where 4e54a5a of PR #342117 is missing.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@phip1611
Copy link
Contributor Author

Ehhh... no idea why a gazillion of reviewers have been requested automatically. Sorry!

@arianvp arianvp closed this Sep 26, 2024
@phip1611
Copy link
Contributor Author

@arianvp Why did you close this fix?

@K900
Copy link
Contributor

K900 commented Sep 26, 2024

Please submit a new PR to avoid any change on this mass-pinging more people.

@NixOS NixOS locked as spam and limited conversation to collaborators Sep 26, 2024
@phip1611 phip1611 deleted the linux-6-11-perf-fix branch September 26, 2024 12:32
@phip1611 phip1611 restored the linux-6-11-perf-fix branch September 26, 2024 12:32
@phip1611 phip1611 deleted the linux-6-11-perf-fix branch September 26, 2024 12:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants