Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cups: apply patches for CVE-2024-47175 #344919

Merged
merged 1 commit into from
Sep 28, 2024

Conversation

LeSuisse
Copy link
Contributor

Description of changes

Based on the information provided in https://www.openwall.com/lists/oss-security/2024/09/27/3

GHSA-7xfx-47qg-grp6

Things done

  • Built on platform(s)
    • x86_64-linux (on top of master)
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/cups-cups-filters-and-libppd-security-issues/52780/1

Copy link
Member

@leona-ya leona-ya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The nixos tests work fine on my machine and the ofborg failure seems related to staging-foo.

@leona-ya leona-ya merged commit d3b4ec2 into NixOS:staging Sep 28, 2024
32 checks passed
Copy link
Contributor

Backport failed for staging-24.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin staging-24.05
git worktree add -d .worktree/backport-344919-to-staging-24.05 origin/staging-24.05
cd .worktree/backport-344919-to-staging-24.05
git switch --create backport-344919-to-staging-24.05
git cherry-pick -x 053e3fe1f4b5602f05084dba63be651592069231

@LeSuisse LeSuisse added 9.needs: port to stable A PR needs a backport to the stable release. and removed backport staging-24.05 Backport PR automatically labels Sep 28, 2024
@LeSuisse
Copy link
Contributor Author

LeSuisse commented Sep 28, 2024

I'm going to deal with the backport.

Edit: Done in #345101

@LeSuisse LeSuisse deleted the cups-CVE-2024-47175 branch September 28, 2024 08:46
@LeSuisse LeSuisse added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants