-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gmt: adoption by the geospatial team #344941
Conversation
Result of 5 packages built:
|
5110ad1
to
7590d8a
Compare
Result of 5 packages built:
|
This all sounds fine with me! Admittedly, I haven’t been doing as much GIS for my work, and I no longer am using a NixOS machine as a daily driver (just macOS computers w/ nixpkgs installs that I infrequently update), so having more eyes on this than just me is probably better for the community.TaylorOn Sep 27, 2024, at 1:54 PM, Augustin Trancart ***@***.***> wrote:
Result of nixpkgs-review pr 344941 run on x86_64-linux 1
5 packages built:
gmt
python311Packages.pygmt
python311Packages.pygmt.dist
python312Packages.pygmt
python312Packages.pygmt.dist
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Result of 4 packages marked as broken and skipped:
1 package built:
|
It looks like we can remove it now: nixpkgs/pkgs/development/python-modules/pygmt/default.nix Lines 70 to 71 in 240ba84
|
@sikmir updated. I've put the geospatial team as maintainers of pygmt as well, while I was at it. |
Drafting this until #340707 is merged. |
@autra would you like to close this? Or perhaps make the PR only be the adoption of the geospation team of the gmt package and related packages? |
I did just that! Thanks for cleaning up before this ;-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now. Thank you.
Description of changes
This MR does 2 things:
About the build fix, it seems to be yet another libxml2 fix. For some reason, the error was about libspatialite, but libspatialite package has already the libxml2 fix.
netcdf
on the other hand, didn't and for some reason, that brought libxml2 without httpSupport for libspatialite too:I don't really understand this (for me libspatialite should get its own libxml2 right?), so please have a look to my fix to ensure it is the correct one.
Another doubt I have: I decided not to patch directly netcdf derivation, but maybe we want this instead (this also fixes the build).
The build failure was discovered when updating geos (#344310)
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.