-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xen: nuke, move to by-name. #345192
xen: nuke, move to by-name. #345192
Conversation
Do package sets work with by-name? |
I don't think so. This also sends all |
I have reached the conclusion I have no idea what I'm doing. |
787325c
to
6d5681b
Compare
Hate to say it, but this is a violation of the It’s also fine to just not be in |
Ah, yes:
|
The problem is that With the |
But you only satisfy that condition because you violate this one:
|
6d5681b
to
dcca5b9
Compare
dcca5b9
to
3bb65e6
Compare
469dc95
to
9938013
Compare
Signed-off-by: Fernando Rodrigues <alpha@sigmasquadron.net>
Signed-off-by: Fernando Rodrigues <alpha@sigmasquadron.net> Co-authored-by: Yaroslav Bolyukin <iam@lach.pw>
As the builder is generic, more people may be using it, so we should try to keep this value as close to the upstream source of truth as possible. Signed-off-by: Fernando Rodrigues <alpha@sigmasquadron.net>
9938013
to
5a2f057
Compare
- Removes the non-slim build instructions, massively simplifying everything in the package. - Removes unecessary patches. - Inherits functions from lib instead of repeating lib.* everywhere. Signed-off-by: Fernando Rodrigues <alpha@sigmasquadron.net>
It was incredibly slow and will be replaced by something r-ryantm can run soon. Signed-off-by: Fernando Rodrigues <alpha@sigmasquadron.net>
Signed-off-by: Fernando Rodrigues <alpha@sigmasquadron.net> Co-authored-by: Yaroslav Bolyukin <iam@lach.pw> Co-authored-by: Emily <vcs@emily.moe>
…ths. Signed-off-by: Fernando Rodrigues <alpha@sigmasquadron.net>
…nd the xenPackages set Signed-off-by: Fernando Rodrigues <alpha@sigmasquadron.net>
Signed-off-by: Fernando Rodrigues <alpha@sigmasquadron.net>
Signed-off-by: Fernando Rodrigues <alpha@sigmasquadron.net>
Signed-off-by: Fernando Rodrigues <alpha@sigmasquadron.net>
They were removed during the great Xen deletion. Signed-off-by: Fernando Rodrigues <alpha@sigmasquadron.net>
Signed-off-by: Fernando Rodrigues <alpha@sigmasquadron.net>
5a2f057
to
ec7ad19
Compare
Description of changes
Things done
nix-shell -p nixpkgs-review --run "nixpkgs-review pr 345192"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.