Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taterclient-ddnet: init at 8.6.0 #346206

Merged
merged 2 commits into from
Oct 20, 2024
Merged

taterclient-ddnet: init at 8.6.0 #346206

merged 2 commits into from
Oct 20, 2024

Conversation

theobori
Copy link
Member

@theobori theobori commented Oct 3, 2024

Add the package taterclient-ddnet.
This is a DDNet-based client that is very popular and used in the community.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Scrumplex
Copy link
Member

Result of nixpkgs-review pr 346206 run on x86_64-linux 1

1 package built:
  • taterclient-ddnet

Copy link
Member

@Scrumplex Scrumplex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs

@Scrumplex
Copy link
Member

Result of nixpkgs-review pr 346206 run on aarch64-darwin 1

@Scrumplex Scrumplex self-requested a review October 13, 2024 12:40
@theobori theobori changed the title taterclient-ddnet: init at 8.5.4 taterclient-ddnet: init at 8.6.0 Oct 13, 2024
@Scrumplex
Copy link
Member

Result of nixpkgs-review pr 346206 run on aarch64-darwin 1

@Scrumplex
Copy link
Member

For some reason nixpkgs-review doesn't detect the new package on darwin?

Anyway, both ddnet and this package build fine, but don't start because theey both try to load libsteam_api.dylib:

dyld[28513]: Library not loaded: /nix/store/9qcrq72n5qvfx1skajjnw4067bsv2d5c-ddnet-18.4/lib/libsteam_api.dylib
  Referenced from: <8FFD8DC0-2313-3485-9855-CB77FB0F038F> /nix/store/9qcrq72n5qvfx1skajjnw4067bsv2d5c-ddnet-18.4/bin/DDNet
  Reason: tried: '/nix/store/9qcrq72n5qvfx1skajjnw4067bsv2d5c-ddnet-18.4/lib/libsteam_api.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/nix/store/9qcrq72n5qvfx1skajjnw4067bsv2d5c-ddnet-18.4/lib/libsteam_api.dylib' (no such file), '/nix/store/9qcrq72n5qvfx1skajjnw4067bsv2d5c-ddnet-18.4/lib/libsteam_api.dylib' (no such file), '/usr/local/lib/libsteam_api.dylib' (no such file), '/usr/lib/libsteam_api.dylib' (no such file, not in dyld cache)
fish: Job 1, 'result/bin/DDNet' terminated by signal SIGABRT (Abort)

@Scrumplex
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 346206


x86_64-linux

✅ 3 packages built:
  • ddnet
  • ddnet-server
  • taterclient-ddnet

@Scrumplex
Copy link
Member

I noticed that the .desktop file points at the wrong binary (Exec=DDNet %u) and also has a name that conflicts with DDNet (share/applications/ddnet.desktop )

@Scrumplex
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 346206


x86_64-linux

✅ 3 packages built:
  • ddnet
  • ddnet-server
  • taterclient-ddnet

Copy link
Member

@Scrumplex Scrumplex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@Scrumplex Scrumplex merged commit dd79602 into NixOS:master Oct 20, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants