Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

streamlink: 6.10.0 -> 6.11.0 #346236

Merged
merged 1 commit into from
Oct 4, 2024
Merged

streamlink: 6.10.0 -> 6.11.0 #346236

merged 1 commit into from
Oct 4, 2024

Conversation

DeeUnderscore
Copy link
Contributor

@DeeUnderscore DeeUnderscore commented Oct 3, 2024 •
edited
Loading

Release notes: https://github.com/streamlink/streamlink/releases/tag/6.11.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested review from zraexy and dezgeg October 3, 2024 21:34
@momeemt
Copy link
Member

momeemt commented Oct 4, 2024

Result of nixpkgs-review pr 346236 run on aarch64-darwin 1

3 packages built:
  • streamlink
  • streamlink.dist
  • wtwitch

momeemt
momeemt approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@momeemt momeemt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@h7x4
Copy link
Member

h7x4 commented Oct 4, 2024

Maybe pytest-asyncio could be removed from check inputs? Changelog mentions that it's no longer needed

@DeeUnderscore
Copy link
Contributor Author

Oh yeah, thanks, dropped pytest-asyncio.

@h7x4 h7x4 merged commit d3c260e into NixOS:master Oct 4, 2024
25 of 26 checks passed
@DeeUnderscore DeeUnderscore deleted the update/streamlink-6.11.0 branch October 4, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h7x4 h7x4 h7x4 approved these changes

@momeemt momeemt momeemt approved these changes

@zraexy zraexy Awaiting requested review from zraexy

@dezgeg dezgeg Awaiting requested review from dezgeg

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DeeUnderscore @momeemt @h7x4 @wegank