Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-24.05] percona: update packages, init 8.4 #346437

Merged
merged 10 commits into from
Oct 16, 2024

Conversation

osnyx
Copy link
Contributor

@osnyx osnyx commented Oct 4, 2024

backport of #346027.

Main difference is that the _lts package names continue to point at the 8_0 release stream, to avoid a major release change within the 24.05 release cycle.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@osnyx
Copy link
Contributor Author

osnyx commented Oct 13, 2024

Updated the backport according to the changes in #346027.

I encountered errors when attempting to run Vitess which calls out to
mysqld_safe[1]. Several utilities are needed in order for it to run e.g.
grep, sed, env, ps, date, hostname, etc.

Additionally, if ps, kill, and grep aren't available to
scripts/CMakeLists.txt, mysqld_start can end up getting generated with
syntax errors as FIND_PROC will be substituted into the script template
as an empty string[2][3].

The presence of systemd in percona-server_innovation seems to prevent
mysqld_multi from being built on Linux so it gets patched conditionally.

This same patch could be applied to MySQL if desired.

[1]: https://github.com/vitessio/vitess/blob/v20.0.1/go/vt/mysqlctl/mysqld.go#L363-L369
[2]: https://github.com/percona/percona-server/blob/79c1086e8272ea96f162b25121b58e1b01ff853b/scripts/CMakeLists.txt#L255
[3]: https://github.com/percona/percona-server/blob/79c1086e8272ea96f162b25121b58e1b01ff853b/scripts/mysqld_safe.sh#L869

(cherry picked from commit a5dcd41)
When reworking the percona package naming towards the two release
streams "innovation" and "lts", I did not anticipate the case that two
releases are long-term supported in parallel, and that the latest
Innovation release is end-of-life and replaced by a more recent lts.

Hence, the first-level attribute names now reflect the package
major-minor versions again, augmented by attribute names pointing to
respective lts and innovation releases.

(cherry picked from commit 188b5df)
This is a new LTS release as well.

(cherry picked from commit 712028e)
This is a new LTS release as well.

(cherry picked from commit b04c93f)
(cherry picked from commit 8d14fa2)
In the stable branch, the `_lts` package names for percona-server and
percona-xtrabackup remain at the still suported 8_0 packages to avoid
major version bumps during a release cycle.
@osnyx osnyx force-pushed the PL-132970-percona-84-backport branch from ae040bb to faa0c49 Compare October 15, 2024 20:18
@ofborg ofborg bot requested a review from Ma27 October 15, 2024 21:33
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FTR: innovation was designed to be the latest feature-release, hence the upgrade to 8.4 is acceptable here (similar examples are linux_latest or nixVersions.git).

The diff in the cherry-pick job is unrelated (stdenv.hostPlatform.is* vs stdenv.is* mostly).

@Ma27 Ma27 merged commit 9ec6dcc into NixOS:release-24.05 Oct 16, 2024
23 of 25 checks passed
@Ma27 Ma27 deleted the PL-132970-percona-84-backport branch October 16, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants