gruvbox-kvantum: init at 1.1 #346465
Closed
gruvbox-kvantum: init at 1.1 #346465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istudyatuni
force-pushed
the
init-gruvbox-kvantum
branch
from
489604f
to
a349855
Compare
istudyatuni
commented
Oct 4, 2024
Comment on lines
+10
to
+18
| lib.checkListOfEnum "${pname}: variant" | ||
| [ | ||
| "Gruvbox-Dark-Blue" | ||
| "Gruvbox-Dark-Brown" | ||
| "Gruvbox-Dark-Green" | ||
| "Gruvbox_Light_Blue" | ||
| "Gruvbox_Light_Brown" | ||
| "Gruvbox_Light_Green" | ||
| ] |
There was a problem hiding this comment.
Probably it's good idea to rename light themes so it won't contain underscores, but I'm not sure
| stdenvNoCC, | ||
| fetchFromGitHub, | ||
| lib, | ||
| variant ? "Gruvbox-Dark-Brown", |
There was a problem hiding this comment.
I don't know, if other variants will be downloaded from nix cache. How does this work?
istudyatuni
force-pushed
the
init-gruvbox-kvantum
branch
from
a349855
to
b77d656
Compare
|
Seems that after rebasing will be many changes and pings |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gruvbox theme for Kvantum: https://github.com/sachnr/gruvbox-kvantum-themes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.