Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p3x-onenote: 2023.4.117 -> 2024.10.110 #346490

Merged
merged 3 commits into from
Oct 8, 2024
Merged

Conversation

khaneliman
Copy link
Contributor

@khaneliman khaneliman commented Oct 4, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@khaneliman
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 346490


x86_64-linux

✅ 1 package built:
  • p3x-onenote

aarch64-linux

✅ 1 package built:
  • p3x-onenote

x86_64-darwin


aarch64-darwin

@khaneliman
Copy link
Contributor Author

@drupol looks like the checks finished

@drupol drupol merged commit 9e70960 into NixOS:master Oct 8, 2024
25 of 26 checks passed
@khaneliman khaneliman deleted the onenote branch October 8, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants