Searxng rework #346777
Draft
Searxng rework #346777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inx with uwsgi over a socket
13 tasks
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
labels
999eagle
reviewed
Oct 7, 2024
| upstreams.searx.servers."unix:${config.services.uwsgi.instance.vassals.searx.socket}" = { }; | ||
| virtualHosts."${cfg.domain}".locations = { | ||
| "/" = { | ||
| uwsgiPass = "searx"; |
There was a problem hiding this comment.
is there any reason why this needs to be an nginx upstream instead of just configuring uswgiPass = "unix:..."; directly here?
There was a problem hiding this comment.
Good question!
It was conflicting with my config but through the user of explicit uwsgiPass we could drop this again as I can cleanly overwrite it.
Comment on lines
+304
to
+306
| nginx = lib.mkIf cfg.configureNginx { | ||
| extraGroups = [ "searx" ]; | ||
| }; |
There was a problem hiding this comment.
setting systemd.services.nginx.serviceConfig.SupplementaryGroups = ["searx"]; seems like the better option for this
| include ${config.services.nginx.package}/conf/uwsgi_params; | ||
| ''; | ||
| }; | ||
| "/static/".alias = lib.mkDefault "${config.services.searx.package}/share/static/"; |
There was a problem hiding this comment.
Suggested change
| "/static/".alias = lib.mkDefault "${config.services.searx.package}/share/static/"; | |
| "/static/".alias = lib.mkDefault "${cfg.package}/share/static/"; |
| RemainAfterExit = true; | ||
| User = "searx"; | ||
| RuntimeDirectory = "searx"; | ||
| RuntimeDirectoryMode = "750"; |
There was a problem hiding this comment.
we should add RuntimeDirectoryPreserve = "yes"; here to keep the socket dir around over restart/stop-start of searx-init.service.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After discovering that I had missed adding the uwsgi_params to my nginx config I thought we need an option to add a working nginx config automatically.
While I was at it, I also gave the module a spring clean.
Requires #346776
fyi @999eagle
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.