python312Packages.sphinx-mdinclude: fix build, 0.6.1 -> 0.6.2

[JulianFP]

This package was previously marked as broken because of a version mismatch between the version of mistune it required and the version of mistune nixpkgs provided. This has been resolved upstream since omnilib/sphinx-mdinclude#46.

Additionally this package also requires sphinx as an explicit dependency since omnilib/sphinx-mdinclude#70 which I added.

I also updated the package to its newest version while we are at it.

I added myself to the maintainers list since I'm willing to help take care of this package for a while.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[natsukium]

Could you change your commit messages and a PR title from sphinx-mdinclude to python312Packages.sphinx-mdinclude since this is a python library?

Commit names of Python libraries should reflect that they are Python libraries, so write for example python311Packages.numpy: 1.11 -> 1.12. It is highly recommended to specify the current default version to enable automatic build by ofborg. Note that pythonPackages is an alias for python27Packages.

https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/python.section.md#contributing-guidelines-contributing-guidelines

[JulianFP]

Could you change your commit messages and a PR title from sphinx-mdinclude to python312Packages.sphinx-mdinclude since this is a python library?

sure thing, sorry for the oversight. It's changed now

[Atemu]

Diff LGTM and it evidently builds on ofBorg.

@flokli are you okay with @JulianFP adding themselves as a maintainer?

[JulianFP]

@flokli are you okay with @JulianFP adding themselves as a maintainer?

I wrote @flokli an email to the address they specified in maintainer-list.nix on the 13th (over a week ago now). No response yet. I think this should be merged without hearing from them first, after all this unbreaks a package build and it would be great to have this in 24.11. If me adding myself to the maintainers list of this package is a problem then I could also just remove myself again....

[Atemu]

it would be great to have this in 24.11

Btw, this PR would have qualified for a backport at any time, so there is no need to stress out about this.

[JulianFP]

Btw, this PR would have qualified for a backport at any time, so there is no need to stress out about this.

yeah, you are right of course.

Thanks a lot for merging this!