-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python312Packages.sphinx-mdinclude: fix build, 0.6.1 -> 0.6.2 #347002
Conversation
d91f00a
to
bbdbdd6
Compare
Could you change your commit messages and a PR title from
|
bbdbdd6
to
6ffc520
Compare
sure thing, sorry for the oversight. It's changed now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wrote @flokli an email to the address they specified in maintainer-list.nix on the 13th (over a week ago now). No response yet. I think this should be merged without hearing from them first, after all this unbreaks a package build and it would be great to have this in 24.11. If me adding myself to the maintainers list of this package is a problem then I could also just remove myself again.... |
Btw, this PR would have qualified for a backport at any time, so there is no need to stress out about this. |
yeah, you are right of course. Thanks a lot for merging this! |
This package was previously marked as broken because of a version mismatch between the version of mistune it required and the version of mistune nixpkgs provided. This has been resolved upstream since omnilib/sphinx-mdinclude#46.
Additionally this package also requires sphinx as an explicit dependency since omnilib/sphinx-mdinclude#70 which I added.
I also updated the package to its newest version while we are at it.
I added myself to the maintainers list since I'm willing to help take care of this package for a while.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.