-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kamp: init at 0.2.1 #347089
kamp: init at 0.2.1 #347089
Conversation
a5955a1
to
dd937cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for joining us with contributions to nixpkgs
! Super exciting!! 🎉
This is a neat package to add and I've left some comments to help align with nixpkgs
conventions I'm aware of with reference to more information. 📚
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diff LGTM.
Result of nixpkgs-review pr 347089
run on x86_64-linux 1
1 package built:
- kamp
I'd now like to be convinced that the package actually works as intended. Do you have a quick and easy way for us non-users to verify this or perhaps know another user who can easily verify that this works?
Of course, apart from the version check nix run .#kakoune -- -e "$(nix run .#kamp -- init)" Kakoune client should be attached now and command |
Nothing happens when I press semicolon. I can run it via |
@Atemu , The existence of kamp-connect is indeed part of the feature, because If you would like to go further you could create
Checkout the branch and execute:
|
Which are next steps to follow to get merged? |
The steps you've given are a bit too much setup for me to realistically follow as a reviewer not interested in the component. I was able to see it available in kakoune and I trust you tested this to be working fine, so I think this is good to go. |
Kamp, as described from author, is a tool to control Kakoune editor from the command line.
https://github.com/vbauerster/kamp
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.