Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kamp: init at 0.2.1 #347089

Merged
merged 2 commits into from
Oct 19, 2024
Merged

kamp: init at 0.2.1 #347089

merged 2 commits into from
Oct 19, 2024

Conversation

erikeah
Copy link
Contributor

@erikeah erikeah commented Oct 7, 2024

Kamp, as described from author, is a tool to control Kakoune editor from the command line.
https://github.com/vbauerster/kamp

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for joining us with contributions to nixpkgs! Super exciting!! 🎉

This is a neat package to add and I've left some comments to help align with nixpkgs conventions I'm aware of with reference to more information. 📚

maintainers/maintainer-list.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/kamp/package.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/kamp/package.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/kamp/package.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/kamp/package.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/kamp/package.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/kamp/package.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/kamp/package.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/kamp/package.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
Copy link
Member

@Atemu Atemu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM.

Result of nixpkgs-review pr 347089 run on x86_64-linux 1

1 package built:
  • kamp

I'd now like to be convinced that the package actually works as intended. Do you have a quick and easy way for us non-users to verify this or perhaps know another user who can easily verify that this works?

@erikeah
Copy link
Contributor Author

erikeah commented Oct 9, 2024

Diff LGTM.

Result of nixpkgs-review pr 347089 run on x86_64-linux 1
1 package built:

I'd now like to be convinced that the package actually works as intended. Do you have a quick and easy way for us non-users to verify this or perhaps know another user who can easily verify that this works?

Of course, apart from the version check nix run .#kamp -- --version you could also use kamp with kakoune by checking out the branch and running:

nix run .#kakoune -- -e "$(nix run .#kamp -- init)"

Kakoune client should be attached now and command kamp-connect must be available by hitting semicolon.

@Atemu
Copy link
Member

Atemu commented Oct 10, 2024

Nothing happens when I press semicolon. I can run it via :kamp-connect but I have no idea what it's supposed to do.

@erikeah
Copy link
Contributor Author

erikeah commented Oct 10, 2024

@Atemu , The existence of kamp-connect is indeed part of the feature, because kamp init writes to stdout the needed configuration to allow kamp-connect command to be available in kakoune.

If you would like to go further you could create ~/.config/kak/kakrcfile with this config:

eval %sh{kamp init}

Checkout the branch and execute:

  1. nix shell .#kamp .#kakoune .#fzf .#bat
  2. kak
  3. :e flake.nix
  4. :e README.md
  5. :kamp-connect terminal kamp-buffers # This will spot another terminal with fzf which will allow you to choose between currently open buffers.
  6. Select one buffer (Navigate with C-n and C-p and hit Enter to choose)
  7. The selected buffer must be visible in kakoune now.

@erikeah
Copy link
Contributor Author

erikeah commented Oct 19, 2024

Which are next steps to follow to get merged?

@Atemu
Copy link
Member

Atemu commented Oct 19, 2024

The steps you've given are a bit too much setup for me to realistically follow as a reviewer not interested in the component.

I was able to see it available in kakoune and I trust you tested this to be working fine, so I think this is good to go.

@Atemu Atemu merged commit a0b1b92 into NixOS:master Oct 19, 2024
29 checks passed
@erikeah erikeah deleted the kamp-pkg branch October 20, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants