Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

granted: 0.34.1 -> 0.35.2 #347364

Merged
merged 7 commits into from
Oct 27, 2024
Merged

granted: 0.34.1 -> 0.35.2 #347364

merged 7 commits into from
Oct 27, 2024

Conversation

jlbribeiro
Copy link
Member

@jlbribeiro jlbribeiro commented Oct 8, 2024

Also adds updateScript (nix-update-script) and versionCheckHook.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from ivankovnatsky October 9, 2024 00:13
@jlbribeiro jlbribeiro changed the title granted: 0.34.1 -> 0.35.0 granted: 0.34.1 -> 0.35.1 Oct 9, 2024
Copy link
Contributor

@ivankovnatsky ivankovnatsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, I don't use it currently, but otherwise it looks good, thanks.

pkgs/by-name/gr/granted/package.nix Outdated Show resolved Hide resolved
@jlbribeiro
Copy link
Member Author

jlbribeiro commented Oct 9, 2024

@ivankovnatsky I currently use it at work; would you want me to replace you as a maintainer?

edit: Took the liberty of doing just that; please feel free to say you rather just have me be an additional maintainer.
Because I feel maintainer changes are important I'm re-requesting your code review (hope you don't mind), and updating the PR description to reflect that.

(also addressed your whitespace suggestion in the process)

jlbribeiro added a commit to jlbribeiro/nixpkgs that referenced this pull request Oct 9, 2024
@ivankovnatsky
Copy link
Contributor

ivankovnatsky commented Oct 9, 2024

@ivankovnatsky I currently use it at work; would you want me to replace you as a maintainer?

Sure thing, totally makes sense! Thanks.

@pjrm
Copy link
Contributor

pjrm commented Oct 17, 2024

I've tested on aarch64-darwin and x86_64-linux, and it works as expected.

Thanks 🙏

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4696

@pbsds
Copy link
Member

pbsds commented Oct 19, 2024

wow it's jarring to be be about to click the merge button, and see it turn gray due to a merge-conflict

conflict with #347816

@jlbribeiro
Copy link
Member Author

jlbribeiro commented Oct 21, 2024

@pbsds May I kindly ask you to re-review + merge after the force-push? I've resolved the conflicts (caused by the nixfmt commit).
(easier to review that commit separately from the rest).

edit: also updated to v0.35.2, which was released 3 hours ago.

@jlbribeiro jlbribeiro changed the title granted: 0.34.1 -> 0.35.1 granted: 0.34.1 -> 0.35.2 Oct 21, 2024
@Aleksanaa Aleksanaa merged commit 17a5806 into NixOS:master Oct 27, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants