-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
granted: 0.34.1 -> 0.35.2 #347364
granted: 0.34.1 -> 0.35.2 #347364
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry, I don't use it currently, but otherwise it looks good, thanks.
@ivankovnatsky I currently use it at work; would you want me to replace you as a maintainer? edit: Took the liberty of doing just that; please feel free to say you rather just have me be an additional maintainer. (also addressed your whitespace suggestion in the process) |
Removes @ivankovnatsky as maintainer following NixOS#347364 (review)
9450736
to
c7bfa3e
Compare
Sure thing, totally makes sense! Thanks. |
I've tested on aarch64-darwin and x86_64-linux, and it works as expected. Thanks 🙏 |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4696 |
wow it's jarring to be be about to click the merge button, and see it turn gray due to a merge-conflict conflict with #347816 |
Removes @ivankovnatsky as maintainer following NixOS#347364 (review)
c7bfa3e
to
9d47ed1
Compare
@pbsds May I kindly ask you to re-review + merge after the force-push? I've resolved the conflicts (caused by the edit: also updated to |
Also adds
updateScript
(nix-update-script
) andversionCheckHook
.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.