Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-24.05] linux_xanmod, linux_xanmod_latest: 2024-10-12 #348591

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

Shawn8901
Copy link
Contributor

manual backport of #348150

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Shawn8901 Shawn8901 marked this pull request as ready for review October 14, 2024 18:08
@Shawn8901
Copy link
Contributor Author

Can i re-trigger the checks somehow?
i assume they are aborted due to having 348590 closed (i accidentally created it against master, thus it added a ton of people as participant and i am not sure if it auto subscribed them, so i closed it again)

@Atemu
Copy link
Member

Atemu commented Oct 15, 2024

I'm not sure if non-committers are able to do this but if you go into a check there's a button to re-run the checks which I've just clicked.

This has nothing to do with the other PR, it's just GH actions being GH actions.

Copy link
Member

@Atemu Atemu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is only red because GH is having a moment.

@Atemu Atemu merged commit 44411b7 into NixOS:release-24.05 Oct 15, 2024
35 of 53 checks passed
@Shawn8901
Copy link
Contributor Author

I'm not sure if non-committers are able to do this but if you go into a check there's a button to re-run the checks which I've just clicked.

This has nothing to do with the other PR, it's just GH actions being GH actions.

No, that button was not available for me (just the crate badge thing). I thought maybe there is a bot command or so that could re-trigger :) thx for help&merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants