Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release 24.05] soundsource: 5.6.3 -> 5.7.1 #349276

Merged

Conversation

DontEatOreo
Copy link
Member

Backports:
#344186

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@DontEatOreo
Copy link
Member Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 349276


x86_64-darwin

✅ 1 package built:
  • soundsource

aarch64-darwin

✅ 1 package built:
  • soundsource

@NickCao
Copy link
Member

NickCao commented Oct 19, 2024

What's with the failing Check cherry-picks? Are we missing a commit in the middle.

@DontEatOreo
Copy link
Member Author

#325738 Didn't get backported

@JohnRTitor JohnRTitor merged commit bb700ab into NixOS:release-24.05 Oct 24, 2024
28 of 30 checks passed
@DontEatOreo DontEatOreo deleted the backport-344186-to-release-24.05 branch October 24, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants