[Backport release-24.05] legcord: 1.0.1 -> 1.0.2

[wrmilling]

https://github.com/Legcord/Legcord/releases/tag/v1.0.2

Result of nixpkgs-review pr 350123 run on x86_64-linux 1

1 package built:

• legcord

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[water-sucks]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 350123

---

x86_64-linux

✅ 1 package built:

• legcord

[r-vdp]

I think you didn't actually use cherry-pick here, right? Would you mind cherry-picking the commits that you want to backport from the master branch, so that we have git include the cherry-pick information automatically?

[wrmilling]

I think you didn't actually use cherry-pick here, right? Would you mind cherry-picking the commits that you want to backport from the master branch, so that we have git include the cherry-pick information automatically?

Correct, the source build from master has issues with electron on the release branch and armcord/legcord was always a binary build on 24.05. Given we are a month away from 24.11 release, my current thought is to leave it working as is and let the binary build be retired with 24.05. I am backporting the intent (legcord -> 1.0.2) rather than the actual source build in this case.

[wrmilling]

@r-vdp Any objection to moving forward with the merge given the builds are actually different between unstable (source) and release-24.05 (binary/deb)?