-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grap: fix build #350401
base: master
Are you sure you want to change the base?
grap: fix build #350401
Conversation
why both |
@pbsds Done. |
substituteInPlace $out/bin/grap --replace-fail "/usr/bin/env python3" "${lib.getExe finalAttrs.python}" | ||
wrapProgram $out/bin/grap --prefix PYTHONPATH : "$out/${finalAttrs.python.sitePackages}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just make this builder python3Packages.buildPythonApplication
?
}; | ||
|
||
python = (python3.withPackages (ps: with ps; [ setuptools ])); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also this dumb workaround
https://hydra.nixos.org/build/274975545/nixlog/1
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.