globalprotect-openconnect_2: init at 2.3.7

[m1dugh]

The version 2 of globalprotect-openconnect

The package already exists in the registry, however, the version adds considerable breaking changes including
api keys for the frontend.

Things done

• Built on platform(s)

  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin

• Tested, as applicable:

  • x86_64-linux
  • aarch64-linux

• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage

• Tested basic functionality of all binary files (usually in ./result/bin/)

• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module

• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to [pull requests you find important].

[m1dugh]

Result of nixpkgs-review pr 350777 run on x86_64-linux 1

[m1dugh]

Result of nixpkgs-review pr 350777 run on x86_64-linux 1

[m1dugh]

@tomodachi94 If ever you have time to check out this pr ❤️

[tomodachi94]

I'll take a look in a little bit ❤️ thanks for the ping. Another good reviewer would be the maintainer of the regular (globalprotect-openconnect) package, if it exists.

[jerith666]

At first glance this looks like a partial duplicate of #316526 by @Binary-Eater, though that work didn't attempt to package the GUI.

Not sure whether it makes sense to try using this packaging of the GUI with the existing packaging of gpauth & gpclient, or if this packaging of everything is more self-consistent.

I haven't tried this locally yet but will try to find time for that soon.

[m1dugh]

Turns out the gui cannot be compiled with rust as the sources are not available on the github.
Only the binary is available.

[m1dugh]

I feel like, if the gui is used, it makes sense to have all the binaries in one package since gpclient relies on the rest of the binaries to work properly with the gui:

• gpclient calls gpservice
• which calls gpgui in turn
• and so on

[m1dugh]

@wegank The whole package is released under GPL3.0 license I guess 🤔 ? Maybe we could merge your changes from #316526 into the same package, however, removing the original package is harsh for people using the gui without willing to pay for the license I feel .

[Binary-Eater]

The license for the GUI component is not GPLv3 while the rest of the components are. That messiness is main reason why I avoided touching the GUI in packaging work for v2. Since v1 is unmaintained, I did not feel comfortable persisting it.

[Binary-Eater]

That said, I would be more keen on bringing back the v1 globalprotect-openconnect as a separate package than dealing with the proprietary licensed and paidware gui for v2.

[m1dugh]

Maybe we can change the license of the v2 full package to unfree, whilst keeping your packaged version of gpclient and gpauth as gpl3 packages, but I feel like the gui is a nice add to the packages and it requires gpservice which is unpackaged as of now.

[m1dugh]

However, i still feel like we should keep version 1.

[Binary-Eater]

I think I like that. Let's change this package to purely be for the GUI and package all the components together as unfree. I will prepare a separate PR to revert removing v1 but add a warning about V1 being unmaintained. Does that seem reasonable?

[m1dugh]

Seems good to me.

[m1dugh]

I put both gpl3 and unfree licenses and added you as maintainer @Binary-Eater, I still can remove the gpl3 license but I guess it makes more sense to put both.

[Binary-Eater]

Thanks. Will test and review soon. That said, I would be ecstatic if you wanted to be the maintainer for this package @m1dugh.