-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
globalprotect-openconnect_2: init at 2.3.7 #350777
base: master
Are you sure you want to change the base?
Conversation
01df7ea
to
a6d026b
Compare
Result of |
10a1cd4
to
f123c93
Compare
Result of |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@tomodachi94 If ever you have time to check out this pr ❤️ |
I'll take a look in a little bit ❤️ thanks for the ping. Another good reviewer would be the maintainer of the regular ( |
At first glance this looks like a partial duplicate of #316526 by @Binary-Eater, though that work didn't attempt to package the GUI. Not sure whether it makes sense to try using this packaging of the GUI with the existing packaging of I haven't tried this locally yet but will try to find time for that soon. |
Turns out the gui cannot be compiled with rust as the sources are not available on the github. |
I feel like, if the gui is used, it makes sense to have all the binaries in one package since
|
The license for the GUI component is not GPLv3 while the rest of the components are. That messiness is main reason why I avoided touching the GUI in packaging work for v2. Since v1 is unmaintained, I did not feel comfortable persisting it. |
That said, I would be more keen on bringing back the v1 globalprotect-openconnect as a separate package than dealing with the proprietary licensed and paidware gui for v2. |
Maybe we can change the license of the v2 full package to unfree, whilst keeping your packaged version of gpclient and gpauth as gpl3 packages, but I feel like the gui is a nice add to the packages and it requires gpservice which is unpackaged as of now. |
However, i still feel like we should keep version 1. |
I think I like that. Let's change this package to purely be for the GUI and package all the components together as unfree. I will prepare a separate PR to revert removing v1 but add a warning about V1 being unmaintained. Does that seem reasonable? |
Seems good to me. |
I put both gpl3 and unfree licenses and added you as maintainer @Binary-Eater, I still can remove the gpl3 license but I guess it makes more sense to put both. |
Thanks. Will test and review soon. That said, I would be ecstatic if you wanted to be the maintainer for this package @m1dugh. |
The version 2 of globalprotect-openconnect
The package already exists in the registry, however, the version adds considerable breaking changes including
api keys for the frontend.
Things done
Built on platform(s)
Tested, as applicable:
Tested compilation of all packages that depend on this change using
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usageTested basic functionality of all binary files (usually in
./result/bin/
)24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
Fits CONTRIBUTING.md.
Add a 👍 reaction to [pull requests you find important].