emacsPackages: clean the things up #351056
Conversation
There was a problem hiding this comment.
It would be good to put this doc into Nixpkgs manual. https://nixos.org/manual/nixpkgs/unstable/#chap-language-support is a good place.
There was a problem hiding this comment.
What is motivation of factoring out this lib-update-scripts.sh? It has only one consumer and factoring out it adds complexity like SOURCE and DIR.
There was a problem hiding this comment.
I am cogitating to split the functions here so that they could be loaded via source lib-update-scripts.sh and so be executed interactively.
E.g. the function that tests the package set can be run whether the set was generated locally or downloaded from the overlay.
There was a problem hiding this comment.
Sounds good. What about adding that to the doc?
There was a problem hiding this comment.
I have documented it.
pkgs/applications/editors/emacs/elisp-packages/lib-update-scripts.sh
Outdated
Show resolved
Hide resolved
pkgs/applications/editors/emacs/elisp-packages/elpa-devel-generated.nix
Outdated
Show resolved
Hide resolved
| The easiest one is to download and commit the package sets from [`nix-community` | ||
| Emacs Overlay](https://github.com/nix-community/emacs-overlay). The script |
There was a problem hiding this comment.
I recommend using Semantic Line Breaks which is used at many places, such as Nix RFCs.
AndersonTorres
force-pushed
the
elisp
branch
5 times, most recently
from
9cae614
to
af1a662
Compare
AndersonTorres
force-pushed
the
elisp
branch
7 times, most recently
from
e110470
to
6539e9f
Compare
This comment was marked as resolved.
This comment was marked as resolved.
By putting them on a separate file `lib-update-scripts.sh`, the file can be `source`'d and so the functions can be used in both batch and interactive environments.
They are practically identical. Let's merge them in a single script. Now they can be called via `./update-package-sets <package sets>`.
They will be gathered in a more fitting documentation.
For now it has documentation for bulk updaters.
Basically, rework the bulk updating framework.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.