-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
emacsPackages: clean the things up #351056
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding documentation is always good.
Please remove those commits updating elisp packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to put this doc into Nixpkgs manual. https://nixos.org/manual/nixpkgs/unstable/#chap-language-support is a good place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is motivation of factoring out this lib-update-scripts.sh
? It has only one consumer and factoring out it adds complexity like SOURCE
and DIR
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am cogitating to split the functions here so that they could be loaded via source lib-update-scripts.sh
and so be executed interactively.
E.g. the function that tests the package set can be run whether the set was generated locally or downloaded from the overlay.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. What about adding that to the doc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have documented it.
pkgs/applications/editors/emacs/elisp-packages/lib-update-scripts.sh
Outdated
Show resolved
Hide resolved
pkgs/applications/editors/emacs/elisp-packages/elpa-devel-generated.nix
Outdated
Show resolved
Hide resolved
The easiest one is to download and commit the package sets from [`nix-community` | ||
Emacs Overlay](https://github.com/nix-community/emacs-overlay). The script |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend using Semantic Line Breaks which is used at many places, such as Nix RFCs.
9cae614
to
af1a662
Compare
e110470
to
6539e9f
Compare
This comment was marked as resolved.
This comment was marked as resolved.
By putting them on a separate file `lib-update-scripts.sh`, the file can be `source`'d and so the functions can be used in both batch and interactive environments.
They are practically identical. Let's merge them in a single script. Now they can be called via `./update-package-sets <package sets>`.
They will be gathered in a more fitting documentation.
For now it has documentation for bulk updaters.
Basically, rework the bulk updating framework.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.