-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go-dnscollector: init package #351194
go-dnscollector: init package #351194
Conversation
Signed-off-by: Vincent Palmer <shift@someone.section.me>
Can you format your code using |
Signed-off-by: Vincent Palmer <shift@someone.section.me>
6f1e4bb
to
249b23b
Compare
As requested:
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is missing some https://github.com/dmachard/go-dnscollector/blob/v1.1.0/Makefile#L21-L24 # result/bin/go-dnscollector -version
# (empty newline) Is this something you feel confident fixing yourself @shift? |
Inited the go-dnscollector package. and added myself to the maintainers.
Things done
Built and tested on multiple x86_64 machines.
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
./result/bin/
)