go-dnscollector: init package

[shift]

Inited the go-dnscollector package. and added myself to the maintainers.

Things done

Built and tested on multiple x86_64 machines.

• Built on platform(s)
  • [*] x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• [*] Tested, as applicable:
• [*] Tested basic functionality of all binary files (usually in ./result/bin/)
• Fits CONTRIBUTING.md.

[m1dugh]

Can you format your code using nixfmt-rfc-style, and run nixpkgs-review pr 3511194 and give us the output of the tool ? (see https://github.com/Mic92/nixpkgs-review)

[shift]

As requested:

$ git -c fetch.prune=false fetch --no-tags --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0 pull/351194/head:refs/nixpkgs-review/1
remote: Enumerating objects: 5473135, done.
remote: Counting objects: 100% (5170323/5170323), done.
remote: Compressing objects: 100% (1252954/1252954), done.
remote: Total 5134512 (delta 3549862), reused 5107163 (delta 3524899), pack-reused 0 (from 0)
Receiving objects: 100% (5134512/5134512), 3.87 GiB | 10.48 MiB/s, done.
Resolving deltas: 100% (3549862/3549862), completed with 8159 local objects.
^[From https://github.com/NixOS/nixpkgs
 * [new branch]                master                -> refs/nixpkgs-review/0
 * [new ref]                   refs/pull/351194/head -> refs/nixpkgs-review/1
$ git worktree add /home/shift/.cache/nixpkgs-review/pr-351194/nixpkgs 18536bf04cd71abd345f9579158841376fdd0c5a
Preparing worktree (detached HEAD 18536bf04cd7)
Updating files: 100% (43781/43781), done.
HEAD is now at 18536bf04cd7 bant: 0.1.7 fix changed hash of fixed derivation. (#350381)
$ nix-env --extra-experimental-features no-url-literals --option system x86_64-linux -f <nixpkgs> --nix-path nixpkgs=/home/shift/.cache/nixpkgs-review/pr-351194/nixpkgs nixpkgs-overlays=/tmp/tmpuzc_ett8 -qaP --xml --out-path --show-trace --no-allow-import-from-derivation
$ git merge --no-commit --no-ff 249b23be312c765e61ae9c92d38be0b083197d2f
Automatic merge went well; stopped before committing as requested
$ nix-env --extra-experimental-features no-url-literals --option system x86_64-linux -f <nixpkgs> --nix-path nixpkgs=/home/shift/.cache/nixpkgs-review/pr-351194/nixpkgs nixpkgs-overlays=/tmp/tmpuzc_ett8 -qaP --xml --out-path --show-trace --no-allow-import-from-derivation --meta
1 package added:
go-dnscollector (init at 1.1.0)

$ nix build --file /nix/store/izlcym2d2x85l64ihpavaqaj7dqsilsm-nixpkgs-review-2.10.4/lib/python3.11/site-packages/nixpkgs_review/nix/review-shell.nix --nix-path nixpkgs=/home/shift/.cache/nixpkgs-review/pr-351194/nixpkgs nixpkgs-overlays=/tmp/tmpuzc_ett8 --extra-experimental-features nix-command no-url-literals --no-link --keep-going --no-allow-import-from-derivation --option build-use-sandbox relaxed --argstr system x86_64-linux --argstr nixpkgs-path /home/shift/.cache/nixpkgs-review/pr-351194/nixpkgs --argstr nixpkgs-config-path /tmp/tmps1_47yal.nix --argstr attrs-path /home/shift/.cache/nixpkgs-review/pr-351194/attrs.nix

Link to currently reviewing PR:
https://github.com/NixOS/nixpkgs/pull/351194

1 package built:
go-dnscollector

$ /nix/store/x6b4rr799djkf8a2abwf59fadcbyasc1-nix-2.18.8/bin/nix-shell --argstr system x86_64-linux --argstr nixpkgs-path /home/shift/.cache/nixpkgs-review/pr-351194/nixpkgs --argstr nixpkgs-config-path /tmp/tmps1_47yal.nix --argstr attrs-path /home/shift/.cache/nixpkgs-review/pr-351194/attrs.nix --nix-path nixpkgs=/home/shift/.cache/nixpkgs-review/pr-351194/nixpkgs nixpkgs-overlays=/tmp/tmpuzc_ett8 /nix/store/izlcym2d2x85l64ihpavaqaj7dqsilsm-nixpkgs-review-2.10.4/lib/python3.11/site-packages/nixpkgs_review/nix/review-shell.nix
these 3 paths will be fetched (1.70 MiB download, 10.90 MiB unpacked):
  /nix/store/k56w4s2vav93hir7lsfw0qkqd97qvqkr-bash-interactive-5.2p32
  /nix/store/53iigsmf32bwkfdhhihq2rppgk23k2rg-ncurses-6.4.20221231
  /nix/store/9jalcr5c2zr5k6nl27sy333xjmaxm9aq-readline-8.2p13
copying path '/nix/store/53iigsmf32bwkfdhhihq2rppgk23k2rg-ncurses-6.4.20221231' from 'https://cache.nixos.org'...
copying path '/nix/store/9jalcr5c2zr5k6nl27sy333xjmaxm9aq-readline-8.2p13' from 'https://cache.nixos.org'...
copying path '/nix/store/k56w4s2vav93hir7lsfw0qkqd97qvqkr-bash-interactive-5.2p32' from 'https://cache.nixos.org'...```

[Scrumplex]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 351194

---

x86_64-linux

✅ 1 package built:

• go-dnscollector

[Scrumplex]

LGTM

[emilylange]

This is missing some ldflags for embedding version info.

https://github.com/dmachard/go-dnscollector/blob/v1.1.0/Makefile#L21-L24
https://github.com/dmachard/go-dnscollector/blob/v1.1.0/.goreleaser.yml#L12-L15

# result/bin/go-dnscollector -version

# (empty newline)

Is this something you feel confident fixing yourself @shift?
And if you want you can add a version test as well.