Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bitwarden-desktop: add aarch64-linux support #351355

Merged
merged 1 commit into from
Oct 27, 2024

Conversation

jackoe
Copy link
Contributor

@jackoe jackoe commented Oct 26, 2024

I added aarch64-linux for bitwarden's desktop client. I've tested it and it works without issue. The only changes required relate to two directory names that are platform dependent.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@FliegendeWurst FliegendeWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Please make sure your commit message follows CONTRIBUTING.md

@jackoe jackoe force-pushed the bitwarden-desktop-aarch64-support branch from 547d8d5 to 02861d7 Compare October 26, 2024 15:07
@jackoe
Copy link
Contributor Author

jackoe commented Oct 26, 2024

hold up going to squash those two commits together

@jackoe jackoe force-pushed the bitwarden-desktop-aarch64-support branch from 516e09a to 9c28d1f Compare October 26, 2024 16:05
@jackoe
Copy link
Contributor Author

jackoe commented Oct 26, 2024

squashed

Copy link
Member

@amarshall amarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I don’t have aarch64 platform available so cannot easily test.

Please also update the PR title to match the commit message format, and then one other small comment.

pkgs/by-name/bi/bitwarden-desktop/package.nix Outdated Show resolved Hide resolved
@jackoe jackoe changed the title add aarch64-linux support for bitwarden-desktop bitwarden-desktop: add aarch64-linux support Oct 26, 2024
@jackoe jackoe force-pushed the bitwarden-desktop-aarch64-support branch from 9c28d1f to 5f4a216 Compare October 26, 2024 19:52
Copy link
Member

@amarshall amarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. One thing I’ll note is that upstream doesn’t, afaik, officially support aarch64-linux (and I don’t have a dev env for it either), so support for the platform here will likely be limited.

@jackoe jackoe force-pushed the bitwarden-desktop-aarch64-support branch from 5f4a216 to 1dd2806 Compare October 27, 2024 00:26
@mweinelt mweinelt merged commit 89ece45 into NixOS:master Oct 27, 2024
10 of 11 checks passed
@jackoe jackoe deleted the bitwarden-desktop-aarch64-support branch October 27, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants