Workflow security fixes #351446
Merged
Workflow security fixes #351446
+39
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: 13x1 <tori@disroot.org> Co-Authored-By: basti564 <e3e@disroot.org>
read-all permissions gives access to e.g. security-events, which these don't need, and can easily lead to leaks Co-Authored-By: 13x1 <tori@disroot.org> Co-Authored-By: basti564 <e3e@disroot.org>
In the previous two commits, security issues with these workflows were fixed. In order for these to not be exploitable for PRs to branches that don't have the fixes yet (including read-only branches like nixos-unstable), these workflows are renamed, so that the old ones can be turned off manually via GitHub interface. Co-Authored-By: 13x1 <tori@disroot.org> Co-Authored-By: basti564 <e3e@disroot.org>
infinisil
added a commit
that referenced
this pull request
Oct 26, 2024
|
Thanks for the ping and backports. Does the app credential have been rotated? (And arghhhhhh GHA are minefield for anything non trivial :/ ) |
|
@LeSuisse No need to, the private key couldn't be leaked, while the tokens generated from it are revoked after the workflow completes, and if something went wrong in 1 hour at the latest. |
|
And yeah GitHub Actions are a tricky beast, I'm very thankful to have been made aware of these problems! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At NixCon we've had 13x1 and @basti564 report security problems with some Nixpkgs workflows, thank you! See the commit messages and contents for more details.
I explained these changes to @Mic92, so that he could immediately merge it.
We disabled the old compromised workflows, so that they wouldn't run anymore for all branches.
Ping @NixOS/security
Add a 👍 reaction to pull requests you find important.