Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

htop: backport configuration path fix #351463

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Scrumplex
Copy link
Member

@Scrumplex Scrumplex commented Oct 26, 2024

See htop-dev/htop#1412

This is useful if the htop configuration is managed by something like Home Manager.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@SuperSandro2000
Copy link
Member

So what is preventing us from undrafting this?

@Scrumplex Scrumplex marked this pull request as ready for review October 26, 2024 19:47
@Scrumplex
Copy link
Member Author

So what is preventing us from undrafting this?

It was just me being too distracted with other things during NixCon. This is ready for review ^^

See htop-dev/htop#1412

This is useful if the htop configuration is managed by something like
Home Manager.

Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
@Scrumplex Scrumplex force-pushed the pkgs/htop/backport-config-patch branch from 80d447a to 4cdef76 Compare October 26, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants