-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
graalvm-ce: fixed native-image on darwin by adding missing nix env variables #351494
base: master
Are you sure you want to change the base?
Conversation
''; | ||
postInstall = | ||
let | ||
darwinArgs = lib.optionals stdenv.hostPlatform.isDarwin [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost sure that we also want to apply those to non-Darwin systems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe. But for the reasons unknown it works for me on a variety of Linux machines, only Darwin is broken.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason I am assuming it works is because on Linux, GraalVM doesn't need any extra libraries. So it works, unless the library you're trying to build needs some third party C library (via JNI for example).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I've changed that.
I will see if I can find time to review this PR, but I think I will remove myself from GraalVM maintainers since I am not using this anywhere anymore. |
77b97a3
to
83bad65
Compare
closes #350909
Addresses the problem introduced by the upstream. GraalVM started sanitizing the environment, so Nix wrappers fail: oracle/graal#7502