graalvm-ce: fixed native-image on darwin by adding missing nix env variables #351494
+33
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pshirshov
changed the title
| ''; | ||
| postInstall = | ||
| let | ||
| darwinArgs = lib.optionals stdenv.hostPlatform.isDarwin [ |
There was a problem hiding this comment.
Almost sure that we also want to apply those to non-Darwin systems.
There was a problem hiding this comment.
Maybe. But for the reasons unknown it works for me on a variety of Linux machines, only Darwin is broken.
There was a problem hiding this comment.
The reason I am assuming it works is because on Linux, GraalVM doesn't need any extra libraries. So it works, unless the library you're trying to build needs some third party C library (via JNI for example).
There was a problem hiding this comment.
Ok, I've changed that.
|
I will see if I can find time to review this PR, but I think I will remove myself from GraalVM maintainers since I am not using this anywhere anymore. |
pshirshov
force-pushed
the
graalvm-ce-darwin-bugfix
branch
from
77b97a3
to
83bad65
Compare
ofborg
bot
requested review from
hlolli,
thiagokokada,
glittershark,
bennyandresen and
ericdallo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #350909
Addresses the problem introduced by the upstream. GraalVM started sanitizing the environment, so Nix wrappers fail: oracle/graal#7502