Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
meta
NOTE:
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
had broken deps related tosvg2tikz
. This appears to be an upstream issue withsvg2tikz
in that the code references functions that are no longer available in 1.4 (or are otherwise renamed). I'm not sure what the best practice is here, but I feel it would be a bit silly to hold back some major improvements brought by 1.4 over a single extension. I've marked svg2tikz as broken and will create an issue for it.I've tested the binary on
x86_64-linux
and onaarch64-darwin
and the program appears to function as it should.The results from
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
(after markingsvg2tikz
as broken):The results from
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
(before markingsvg2tikz
as broken):The error in upstream svg2tikz appears to be here:
https://github.com/xyz2tex/svg2tikz/blob/89d17219ac22d80570a8171bb1d4b01700787fba/svg2tikz/tikz_export.py#L822
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.