Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inkscape: 1.3.2 -> 1.4 #351517

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 12 additions & 23 deletions pkgs/applications/graphics/inkscape/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
, callPackage
, cmake
, desktopToDarwinBundle
, double-conversion
, fetchurl
, fetchpatch
, gettext
, ghostscript
, glib
Expand Down Expand Up @@ -65,15 +65,16 @@ let
pyserial
requests
pygobject3
tinycss2
] ++ inkex.propagatedBuildInputs);
in
stdenv.mkDerivation rec {
pname = "inkscape";
version = "1.3.2";
version = "1.4";

src = fetchurl {
url = "https://inkscape.org/release/inkscape-${version}/source/archive/xz/dl/inkscape-${version}.tar.xz";
sha256 = "sha256-29GETcRD/l4Q0+mohxROX7ciOFL/8ZHPte963qsOCGs=";
sha256 = "sha256-xZqFRTtpmt3rzVHB3AdoTdlqEMiuxxaxlVHbUFYuE/U=";
};

# Inkscape hits the ARGMAX when linking on macOS. It appears to be
Expand All @@ -94,22 +95,6 @@ stdenv.mkDerivation rec {
src = ./fix-ps2pdf-path.patch;
inherit ghostscript;
})

# Fix build with libxml2 2.12
# https://gitlab.com/inkscape/inkscape/-/merge_requests/6089
(fetchpatch {
url = "https://gitlab.com/inkscape/inkscape/-/commit/694d8ae43d06efff21adebf377ce614d660b24cd.patch";
hash = "sha256-9IXJzpZbNU5fnt7XKgqCzUDrwr08qxGwo8TqnL+xc6E=";
})

# Improve distribute along path precision
# https://gitlab.com/inkscape/extensions/-/issues/580
(fetchpatch {
url = "https://gitlab.com/inkscape/extensions/-/commit/c576043c195cd044bdfc975e6367afb9b655eb14.patch";
extraPrefix = "share/extensions/";
stripLen = 1;
hash = "sha256-D9HxBx8RNkD7hHuExJqdu3oqlrXX6IOUw9m9Gx6+Dr8=";
})
];

postPatch = ''
Expand Down Expand Up @@ -141,6 +126,7 @@ stdenv.mkDerivation rec {
buildInputs = [
boehmgc
boost
double-conversion
gettext
glib
glibmm
Expand Down Expand Up @@ -184,12 +170,15 @@ stdenv.mkDerivation rec {

passthru.tests.ps2pdf-plugin = callPackage ./test-ps2pdf-plugin.nix { };

meta = with lib; {
meta = {
description = "Vector graphics editor";
homepage = "https://www.inkscape.org";
license = licenses.gpl3Plus;
maintainers = [ maintainers.jtojnar ];
platforms = platforms.all;
license = lib.licenses.gpl3Plus;
maintainers = with lib.maintainers; [
jtojnar
x123
];
platforms = lib.platforms.all;
mainProgram = "inkscape";
longDescription = ''
Inkscape is a feature-rich vector graphics editor that edits
Expand Down
15 changes: 2 additions & 13 deletions pkgs/development/python-modules/inkex/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
stdenv,
buildPythonPackage,
inkscape,
fetchpatch,
poetry-core,
cssselect,
lxml,
Expand All @@ -14,6 +13,7 @@
pyparsing,
pyserial,
scour,
tinycss2,
gobject-introspection,
pytestCheckHook,
gtk3,
Expand All @@ -27,17 +27,6 @@ buildPythonPackage {

inherit (inkscape) src;

patches = [
# Fix “distribute along path” test with Python 3.12.
# https://gitlab.com/inkscape/extensions/-/issues/580
(fetchpatch {
url = "https://gitlab.com/inkscape/extensions/-/commit/c576043c195cd044bdfc975e6367afb9b655eb14.patch";
extraPrefix = "share/extensions/";
stripLen = 1;
hash = "sha256-D9HxBx8RNkD7hHuExJqdu3oqlrXX6IOUw9m9Gx6+Dr8=";
})
];

nativeBuildInputs = [ poetry-core ];

propagatedBuildInputs = [
Expand All @@ -46,6 +35,7 @@ buildPythonPackage {
numpy
pygobject3
pyserial
tinycss2
];

pythonImportsCheck = [ "inkex" ];
Expand Down Expand Up @@ -88,7 +78,6 @@ buildPythonPackage {

substituteInPlace pyproject.toml \
--replace-fail 'scour = "^0.37"' 'scour = ">=0.37"' \
--replace-fail 'lxml = "^4.5.0"' 'lxml = "^4.5.0 || ^5.0.0"'
'';

meta = {
Expand Down
1 change: 1 addition & 0 deletions pkgs/development/python-modules/svg2tikz/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -51,5 +51,6 @@ buildPythonPackage rec {
dotlambda
gal_bolle
];
broken = true;
};
}