Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fnlfmt: use included Makefile for build #351547

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joshbode
Copy link

@joshbode joshbode commented Oct 27, 2024

Solves missing fnlfmt pagkage error since it is not being inlined.

Currently, this error is being encountered:

$ fnlfmt --help

/nix/store/k6ms9frir783p3fs3c3fjb9rc8jkkp2p-lua-5.2.4/bin/lua: ...65hbid7205ziz5i25vjw3gmixjxyjddh-fnlfmt-0.3.2/bin/fnlfmt:6727: module 'fnlfmt' not found:
        no field package.preload['fnlfmt']
        no file '/nix/store/k6ms9frir783p3fs3c3fjb9rc8jkkp2p-lua-5.2.4/share/lua/5.2/fnlfmt.lua'
        no file '/nix/store/k6ms9frir783p3fs3c3fjb9rc8jkkp2p-lua-5.2.4/share/lua/5.2/fnlfmt/init.lua'
        no file '/nix/store/k6ms9frir783p3fs3c3fjb9rc8jkkp2p-lua-5.2.4/lib/lua/5.2/fnlfmt.lua'
        no file '/nix/store/k6ms9frir783p3fs3c3fjb9rc8jkkp2p-lua-5.2.4/lib/lua/5.2/fnlfmt/init.lua'
        no file './fnlfmt.lua'
        no file '/nix/store/k6ms9frir783p3fs3c3fjb9rc8jkkp2p-lua-5.2.4/lib/lua/5.2/fnlfmt.so'
        no file '/nix/store/k6ms9frir783p3fs3c3fjb9rc8jkkp2p-lua-5.2.4/lib/lua/5.2/loadall.so'
        no file './fnlfmt.so'
stack traceback:
        [C]: in function 'require'
        ...65hbid7205ziz5i25vjw3gmixjxyjddh-fnlfmt-0.3.2/bin/fnlfmt:6727: in main chunk
        [C]: in ?

$ tree /nix/store/65hbid7205ziz5i25vjw3gmixjxyjddh-fnlfmt-0.3.2/
/nix/store/65hbid7205ziz5i25vjw3gmixjxyjddh-fnlfmt-0.3.2/
└── bin
    └── fnlfmt

with the change to use the included Makefile then fnlfmt executes as expected:

$ fnlfmt --help

Usage: fnlfmt [--no-comments] [--fix] [--check] FILENAME...
With the --fix or --check argument, multiple files can be specified.
With the --fix argument, formats all the files in-place;
with the --check argument, only checks if all the files are formatted;
otherwise prints the formatted file to stdout.

$ tree /nix/store/7mpxvikyjk4n4vj1v8b2mcr9cj1sclbp-fnlfmt-0.3.2
/nix/store/7mpxvikyjk4n4vj1v8b2mcr9cj1sclbp-fnlfmt-0.3.2
├── bin
│   └── fnlfmt
└── share
    ├── lua
    │   └── 5.2
    │       └── fnlfmt.lua
    └── man
        └── man1
            └── fnlfmt.1.gz

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Solves missing `fnlfmt` pagkage error since it is not being inlined
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant