Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pantheon.elementary-screenshot-tool: fix conceal text #56552

Merged
merged 2 commits into from
Mar 9, 2019
Merged

pantheon.elementary-screenshot-tool: fix conceal text #56552

merged 2 commits into from
Mar 9, 2019

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

The text concealment feature wasn't working.
I recall my main concern before was that I didn't want to expose this font at all.
But whatever I thought I was doing before wasn't working.

Concealed Screenshot

screenshot from 2019-02-28 18 58 27

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: pantheon The Pantheon desktop environment 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 1, 2019
@worldofpeace worldofpeace changed the title pantheon.elementary-screeshot-tool: fix conceal text pantheon.elementary-screenshot-tool: fix conceal text Mar 1, 2019
@jtojnar
Copy link
Member

jtojnar commented Mar 4, 2019

Why not use https://github.com/png2378/redacted-elementary or https://github.com/christiannaths/Redacted-Font

@worldofpeace
Copy link
Contributor Author

Why not use https://github.com/png2378/redacted-elementary or https://github.com/christiannaths/Redacted-Font

I think Christian Naths is the author, so I'll just add it to all-packages.nix from https://github.com/christiannaths/Redacted-Font

@jtojnar
Copy link
Member

jtojnar commented Mar 4, 2019

The fork might have some extra modifications, though.

Also using it in screenshot app is probably a security issue – the redacting seems to be reversible with a dictionary christiannaths/redacted-font#27

@worldofpeace
Copy link
Contributor Author

The fork might have some extra modifications, though.

Looking at the git history, it's mostly imports elementary/fonts@371c7e9.
Looks like they only care about the Script font type.

I'd like to only have one variant of the font in nixpkgs.

Also using it in screenshot app is probably a security issue – the redacting seems to be reversible with a dictionary christiannaths/redacted-font#27

🤣 Yeah I think Pantheon might be interested in improving the font then.

@worldofpeace worldofpeace force-pushed the elementary-screenshot-tool/fix-conceal-text branch from 3057a5f to 59f4708 Compare March 4, 2019 19:12
@worldofpeace
Copy link
Contributor Author

Switched to using https://github.com/png2378/redacted-elementary

@jtojnar
Copy link
Member

jtojnar commented Mar 9, 2019

🤣 Yeah I think Pantheon might be interested in improving the font then.

Could you open an issue with screenshot-tool?

@worldofpeace
Copy link
Contributor Author

Opened https://github.com/elementary/screenshot/issues/126

@worldofpeace worldofpeace merged commit fa64c63 into NixOS:master Mar 9, 2019
@worldofpeace worldofpeace deleted the elementary-screenshot-tool/fix-conceal-text branch March 9, 2019 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: pantheon The Pantheon desktop environment 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@worldofpeace @jtojnar @GrahamcOfBorg