chore(CI): run tests on CentOS 7 #494
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Apr 29, 2023
.github/workflows/ci.yml
Outdated
| make -j$(nproc) check || (cat tests/test-suite.log; exit 1) | ||
| EOF | ||
|
|
||
| docker run -v $(pwd):/gha quay.io/pypa/manylinux2014_${{ matrix.platform }}:latest sh -ec "cd /gha && sh ./build.sh" |
There was a problem hiding this comment.
What would we need to upgrade to next year when centos 7 is EOL? https://wiki.centos.org/About/Product
There was a problem hiding this comment.
I think either ubuntu 18.04 or AlmaLinux 8 (/manylinux_2_28 which avoid installing a bunch of packages).
I could try to add it now to just be able to drop centos 7.
Bumps [cachix/install-nix-action](https://github.com/cachix/install-nix-action) from 20 to 22. - [Release notes](https://github.com/cachix/install-nix-action/releases) - [Commits](cachix/install-nix-action@v20...v22) --- updated-dependencies: - dependency-name: cachix/install-nix-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…hix/install-nix-action-22 Bump cachix/install-nix-action from 20 to 22
Bumps [docker/setup-qemu-action](https://github.com/docker/setup-qemu-action) from 2 to 3. - [Release notes](https://github.com/docker/setup-qemu-action/releases) - [Commits](docker/setup-qemu-action@v2...v3) --- updated-dependencies: - dependency-name: docker/setup-qemu-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…ker/setup-qemu-action-3 Bump docker/setup-qemu-action from 2 to 3
Works around NixOS#520, may be useful for other cursed self-modifying things.
Bumps [cachix/install-nix-action](https://github.com/cachix/install-nix-action) from 22 to 25. - [Release notes](https://github.com/cachix/install-nix-action/releases) - [Commits](cachix/install-nix-action@v22...v25) --- updated-dependencies: - dependency-name: cachix/install-nix-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
CTAD is not working here. Signed-off-by: Rosen Penev <rosenp@gmail.com>
Bumps [cachix/install-nix-action](https://github.com/cachix/install-nix-action) from 25 to 27. - [Release notes](https://github.com/cachix/install-nix-action/releases) - [Commits](cachix/install-nix-action@v25...V27) --- updated-dependencies: - dependency-name: cachix/install-nix-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [cachix/install-nix-action](https://github.com/cachix/install-nix-action) from V27 to 30. This release includes the previously tagged commit. - [Release notes](https://github.com/cachix/install-nix-action/releases) - [Commits](cachix/install-nix-action@V27...v30) --- updated-dependencies: - dependency-name: cachix/install-nix-action dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
when building and then checking patchelf on openSUSE Leap 15.5, the rename-dynamic-symbols.sh test fails. The test builds a test library and executable called many-syms-main, then runs patchelf to rename symbols and then checks that many-syms-main still runs successfully. On Leap the run fails with many messages like ./many-syms-main: Symbol `f1947' causes overflow in R_X86_64_PC32 relocation and then terminates with a Segmentation fault. The interesting bit is that it however fails so even before patchelf touches it. The binary is built and linked with option -pie which produces an executable which is supposedly position independent but does not actually contain code position independent code which requires compiler option -fPIE (of -fpie or -fPIC or -fpic). As a result the calls in the generated assembly do not go through the PLT. This patch merely adresses that by adding the -fPIE option to the CFLAGS for the test.
glibc: commit: 6f962278e24bdf5cb5f310c5a17add41da95407c Signed-off-by: Michal Biesek <michalbiesek@gmail.com>
All tests pass. Also explicitly specifies -no-pie for executables which should have it disabled, to be compatible with gccs built with --enable-default-pie.
Use pledge(2)[0] to limit patchelf(1) to read, write and create files. It never deals with TTY, network, process management or other subsystems. Do so immediately in main() since mainWrapped() itself parses files whilst parsing command line arguments (--rename-dynamic-symbols). This is to reduce patchelf's attack surface and potential damage when dealing with untrusted ELF programs. No behaviour change in tests or real world usage observed on OpenBSD/amd64 7.4 (0.18.0 tests: 56/52/2/2 TOTAL/PASS/FAIL/SKIP). 0: https://man.openbsd.org/pledge.2
Replace non-portable GNU `-i, --hardware-platform` with `-m[, --machine]` to fix "unknown error" usage error on, e.g. OpenBSD. Also fix the check's backwards logic. OpenBSD/spar64 now prints -skipping test: not supported on x86_64 Linux +skipping test: amd64 Linux required
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v3...v4) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 3 to 4. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@v3...v4)
This also works with the busybox version.
this broke tests on other architectures
After commit ac212d0 the code to rewrite alignment section has been changed to use the largest alignment in the list of segments instead of the alignment that it's retrieved using getPageSize(). Unfortunately the code didn't update the offset as well to keep the invariant p_vaddr % alignment == p_offset % alignment.
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
If the given interpreter is already set, nothing needs to be done. As with modifySoname(), it skips unnecessary processing.
In some cases, ldd can fail on the original binary. In that case it is also observed that running with an explicit interpreter will fail. https://gitlab.com/qemu-project/qemu/-/issues/1763
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards getting reproducers/non-regression tests for #492 which is OS dependent.