Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --add-rpath-and-shrink option to do both operations in one go #570

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Nov 15, 2024

Note: I know this is missing an update of the man-page and tests. I'd like to know if you'd be open to accept such a patch in the first place before investing more time into it.

The core issue is that --shrink-rpath doesn't free up space filled
with X by --add-rpath, so using a combination of --add-rpath &
--shrink-rpath on a virtual env will blow up shared libraries and
cause them to segfault when loaded by Python at some point.

This is not an issue with Nix builds, but it absolutely is when using this
in an imperatively managed virtualenv.

cc @Mic92


Thank you!

Please do your best to include a regression test
so that the quality of future releases can be preserved.

Ma27 added 2 commits November 15, 2024 10:15
The core issue is that `--shrink-rpath` doesn't free up space filled
with `X` by `--add-rpath`, so using a combination of `--add-rpath` &
`--shrink-rpath` on a virtual env will blow up shared libraries and
cause them to segfault when loaded by Python at some point.
@Mic92
Copy link
Member

Mic92 commented Nov 16, 2024

@Ma27 I can probably just give you merge access to this project.
I am currently not doing here much, because it feels a bit difficult to do any meaningful changes without breaking some random corner of nixpkgs.

@Mic92
Copy link
Member

Mic92 commented Nov 16, 2024

Feel free to go ahead with this pull request: https://github.com/orgs/NixOS/teams/patchelf-maintainers/members

@Ma27
Copy link
Member Author

Ma27 commented Dec 11, 2024

So first of all, your trust is greatly appreciated, thanks! ❤️

I'll try to bring this patch into a cleaner state within the next weeks to get it in.

That being said, I'm afraid I won't be able to exercise any further maintainer duties in a forseeable future (i.e. the next few months): I'm working on finishing my studies soonish and I can't afford a(nother) can of worms that a patchelf bump is for now (I know how painful updates in nixpkgs are).

If nothing has changed about the situation here in a few months, I'll reconsider my decision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants