fix: bug#170 (#206)

* Remove mockedFunction for Node.js test runner mock method * use Set to keep track literals removing doubles * add test ensuring doubles morse symbol does not trigger warnings
NodeSecure · Jan 16, 2024 · 0b807a0 · 0b807a0
1 parent 5273190
commit 0b807a0
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 4 deletions.
diff --git a/src/SourceFile.js b/src/SourceFile.js
@@ -30,9 +30,9 @@ export class SourceFile {
     computedMemberExpr: 0,
     memberExpr: 0,
     deepBinaryExpr: 0,
-    encodedArrayValue: 0,
-    morseLiteral: 0
+    encodedArrayValue: 0
   };
+  morseLiterals = new Set();
   identifiersName = [];
 
   constructor(sourceCodeString) {
@@ -107,7 +107,7 @@ export class SourceFile {
 
     // Searching for morse string like "--.- --.--."
     if (Utils.isMorse(str)) {
-      this.counter.morseLiteral++;
+      this.morseLiterals.add(str);
     }
   }
 

diff --git a/src/obfuscators/index.js b/src/obfuscators/index.js
@@ -20,7 +20,7 @@ export function isObfuscatedCode(analysis) {
   else if (jjencode.verify(analysis)) {
     encoderName = "jjencode";
   }
-  else if (analysis.counter.morseLiteral >= 36) {
+  else if (analysis.morseLiterals.size >= 36) {
     encoderName = "morse";
   }
   else {

diff --git a/test/obfuscated.spec.js b/test/obfuscated.spec.js
@@ -36,6 +36,13 @@ test("should not detect 'morse' obfuscation", () => {
   assert.strictEqual(warnings.length, 0);
 });
 
+test("should not detect 'morse' obfuscation for high number of doubles morse symbols", () => {
+  const morseSymbolDoublesString = `const a = ${"'.' + '..' +".repeat(37)} '.'`;
+  const { warnings } = runASTAnalysis(morseSymbolDoublesString);
+
+  assert.strictEqual(warnings.length, 0);
+});
+
 test("should detect 'jjencode' obfuscation", () => {
   const trycatch = readFileSync(
     new URL("jjencode.js", FIXTURE_URL),