change api #10
Draft
change api #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add the verbatim value to the string type enum because this is the offical name in the c# documentation
* Add a ctor to ValueArgument that allows us to escape or non escape the Argument
* Add a TypeSyntax overload to the methodbuilder to allow to work with TypeSyntax objects from roslyn aswell
* Add diffrent overloads to declaration statement to allow to pass typesyntax diffrently and also working without any type
* Add the verbatim value to the string type enum because this is the offical name in the c# documentation
* Add a ctor to ValueArgument that allows us to escape or non escape the Argument
* Add a TypeSyntax overload to the methodbuilder to allow to work with TypeSyntax objects from roslyn aswell
* Add diffrent overloads to declaration statement to allow to pass typesyntax diffrently and also working without any type
* To support new features start to use the preview lang version
* Reorder enums to follow style guide * Use correct using to prevent build issue. Is needed for obsolet flag
* Add new overloads to support also TypeSyntax and Parsing in Declaration statements
* Add a stringValueArgument to seperate String logic from Value logic and parsing
…into work/changeApi
* New overloads are not optional because otherwise compiler can not decide between the diffrent overloads
* Use the property instead the smaller parameter because adding " happens only on Prop
* Fix tests so that all Expectation now correct
…into work/changeApi
* There was a typo in the method names and this commit fix this typo. So assign is now spelled correctly
Resolve Conflicts: src/VaVare/Statements/DeclarationStatement.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.