Accepting pull requests before release #65
Replies: 4 comments
-
or should we just accept them ourselves if the change is accepted by the reviewer(s) ? |
Beta Was this translation helpful? Give feedback.
-
There are two remaining pull requests in CAM (one on redundant code, and one on a preliminary contribute.md). Can they be in the upcoming release? |
Beta Was this translation helpful? Give feedback.
-
I merged the contribute.md, since that was just for all of you to see and possible edit in case it was not ok. For the redundant code, I am confused and added a remark on the pull request. |
Beta Was this translation helpful? Give feedback.
-
I did a test on vilje with the redundant code changes, and it did not affect the results (tested NF1850norbc compset). |
Beta Was this translation helpful? Give feedback.
-
Should we go briefly through the pull requests mid next week so that we can agree on them.
Beta Was this translation helpful? Give feedback.
All reactions